Repository navigation
[settings-panel]: Keep Settings visible and anchored to the tray - #96
Conversation
|
Independent reviews of commit
Author full gates passed: Native stacking/reanchoring and rendered scrolling are explicitly unverified because no connected browser/native UI automation surface is available. Issue 064 and those acceptance criteria remain open. Neither review substitutes unit/component results for GUI evidence; this PR is not merged. |
|
@coderabbitai review |
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Priority: ➖ Normal Merge Risk: ⚪ Minimal · up to
|
✅ Action performedReview finished.
|
|
Checked the CodeRabbit result on head The Biome tool warning is a reviewer-tool version mismatch, not a lint finding in the Settings code. CodeRabbit used Biome 2.5.14 while the repository pins Biome 1.9.4 and its schema. Reproducing with an isolated 2.5.14 CLI fails while parsing The existing independent behavior and rules reviews remain valid. Native GUI acceptance in issue 064 remains open; this note does not certify stacking, anchoring or rendered scrolling. |
93c1e10 to
4d858d8
Compare
|
Fresh reviews of rebased head
Actual native stacking, tray positioning/reanchoring, and rendered scrolling remain unobserved. The user authorized this code merge; issue 064 remains open with those GUI criteria unchecked. This review does not certify GUI acceptance or publish a release. |
Summary
Settings could clip its controls: the host used a fixed 380×300 window while the frontend attempted resizing without the required capability. Open a bounded, scrollable Preferences panel beneath the tray icon and keep it above other windows independently of the Widget setting.
Preserve the Rust-driven notification registry now on
main. Conflict resolution keeps startup seeding removed, retains the registry tests, and extends keyboard coverage through dynamically supplied notification controls, including a future source.Issue: 064 — Settings tray panel
Completion promise:
Evidence
After: Six native geometry regressions cover placement, screen boundaries, window decorations, missing tray geometry, and display scaling. Ten Settings component tests cover updates, the notification registry, and keyboard access through twelve display controls and dynamic notification toggles.
4d858d89ceaf6f9a3edfbab7e301d18bdf220ec5ontomainat67140af412436fdcfb1ae1c89bcde395035c127b, after PR [hooks-upgrade]: Upgrade stale hook plugins before reporting success #95 merged.task check: passed; 342 Rust tests, 179 frontend tests, lint, debug/release Clippy, build/type checks, unused-code checks, and generated-contract checks.task check:windows: passed. Existing unrelated unusedscriptwarning and expected cross-check placeholder-sidecar notice remain.git diff --check: passed. No weakened tests, silenced checks, new dependency, IPC capability, or personal Settings change.Native GUI acceptance remains pending: this session has not observed actual macOS stacking, tray placement, reanchoring, or rendered scrolling. Issue 064 remains open with both GUI acceptance boxes unchecked. Automated tests do not substitute for that evidence. This PR does not publish a release.
Merge Danger
Door: two-way
Code-only change with no data migration; reverting restores the prior Settings behavior.
Blast Radius: Settings
Native window placement and Preferences layout change; platform-specific visual behavior remains the manual verification gap.