Skip to content

[notification-sources]: Notification source settings registry - #98

Merged
archae0pteryx merged 2 commits into
mainfrom
feat/notification-source-settings
Oct 20, 2026
Merged

archae0pteryx merged 2 commits into
mainfrom
feat/notification-source-settings

Conversation

@archae0pteryx

Copy link
Copy Markdown
Contributor

Preferences now loads notification source descriptors from Rust's all_sources() registry through a registered Tauri command and the Settings API/hook. The UI renders the supplied descriptors, so adding a source no longer requires updating a TypeScript list. Existing labels, enabled defaults, settings persistence, and immediate runtime application are preserved.

Implements issue 031's current repository contract. The GitHub issue body predates the Preferences design; this follows the repository issue's explicit exclusion of tray submenu changes. The completed issue record and priority queue are updated.

Completion promise:

Notification toggles in Preferences are driven by the Rust NotificationSource registry, so adding a new source does not require editing the settings UI source list.

Validation: task check and task check:windows passed. Independent implementation review returned PASS and the rules review returned clean. Tests cover registry projection, API/hook wiring, current settings, arbitrary future-source toggles, and existing persistence/live-settings behavior. Native Preferences interaction, settings-file changes through native toggles, and OS notification delivery were not manually observed.

Closes #31.

@coderabbitai

coderabbitai Bot commented Oct 20, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: killallgit/adhd-ranch/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: c1234c26-2c81-4374-89ec-d87327980174

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@archae0pteryx
archae0pteryx merged commit 07483f3 into main Oct 20, 2026
2 checks passed
@archae0pteryx
archae0pteryx deleted the feat/notification-source-settings branch October 20, 2026 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

031 — Notification source settings registry

1 participant