Skip to content

refactor: deepen sidebar presentation and complete Linux CI - #2

Merged
archae0pteryx merged 2 commits into
masterfrom
refactor/presentation-ci
Nov 7, 2026
Merged

archae0pteryx merged 2 commits into
masterfrom
refactor/presentation-ci

Conversation

@archae0pteryx

Copy link
Copy Markdown

Summary

SidebarView → Presentation.Project → Writer delivery
                         ├─ complete token sets
                         ├─ visible repaint deadline
                         └─ plain-stop restoration titles

Linux CI → shared release gates → linux/amd64
                              → darwin/amd64
                              → darwin/arm64
  • Concentrate fold presentation in a pure projection; preserve visible output and stop restoration while removing hidden-carrier age repaints.
  • Exercise folded families, carrier visits, sibling focus, and lone agents through scenario replay and both golden layouts, without introducing a shallow shared observation module.
  • Pin lint/test/security/workflow tools, collect JUnit/JSON/coverage, run tests only on Linux, and require the full reusable quality suite before release packaging.
  • Fix the live integration harness's data race, short socket paths, bounded commands, child race reporting, and cleanup. Keep the existing Beads/project-agent setup included in this branch.
  • Produce only Linux amd64 and macOS amd64/arm64 binaries and tar archives. Keep legacy platform source; do not change existing published releases.
  • Refs herdr-scope-xc7: hosted CI verification and the owner-approved required CI passed branch rule. Branch protection remains a separate approval.

Evidence

  • Before: a hidden carrier's age scheduled an invisible repaint; the real integration run exposed a shared-buffer data race and vacuous long-path socket assertions.
    After: focused regressions passed; 445 offline tests and one isolated live integration test passed with race checking and no skipped cases during implementation. Existing golden output is unchanged; new folded/visiting fixtures cover both layouts.
  • Before: local lint drifted from CI and a release tag could bypass the full quality suite.
    After: pinned tools, workflow/format/module checks, target analysis, compiler checks, and reusable release gates are configured. Hosted Linux CI is the merge gate.
  • Three requested release targets were built and packaged locally; archive contents, executable permissions, checksums, and the absence of Windows/Linux arm64 artifacts were verified. No new macOS or Windows test runs were added after the Linux-only testing decision.

Merge Danger

Door: two-way

No schema or persisted-state migration. Revert restores the prior projection and automation.

Blast Radius: project

Sidebar rendering/timing, developer tooling, and release gates change. New releases intentionally omit Windows and Linux arm64; existing published assets are untouched.

@archae0pteryx

Copy link
Copy Markdown
Author

Independent review

Reviewed head eec4a40e2749f7b2aaa09baef9e12c0eec69efcb with a fresh-context local reviewer. No configured CI reviewer was found. The reviewer found no runtime correctness bug or blocking finding.

Disposition: 0 fixed, 6 declined for this PR.

  1. Release lookup should tolerate failures — declined. The fail-closed behavior is intentional: network/auth/server errors must not masquerade as an absent release. The hosted Cross-compile and install job passed the real prebuilt, source-build, and release-download paths; its log confirms installed the v1.1.2 release binary. The speculative HEAD redirect failure did not reproduce.
  2. Restore Linux arm64 or Windows platform coverage — declined. The requested policy is Linux-only test execution, with release artifacts limited to Linux amd64 and macOS amd64/arm64. Windows CI and Linux arm64 binaries must not be reintroduced. Existing platform source and legacy installers remain available for source builds; binary availability is documented separately.
  3. Derive test packages dynamically — declined. Every current package is covered by the explicit package categories except the intentionally separate live integration suite, which has its own required job. No current test is omitted; introducing a new top-level package category should update that explicit suite selection.
  4. Version-file compatibility — declined as disproven. Action v9.3.0 supports .golangci-lint-version; both hosted analysis jobs passed using that file. The pinned action commit was also checked against its v9.3.0 tag.
  5. Make stable-Go/security checks advisory for releases — declined. Releasing only after the complete quality suite, including vulnerability checks, is the intended policy. A newly discovered reachable vulnerability should block a new release rather than be ignored because the source commit is older.
  6. Branch protection is outside the diff — declined as an in-PR change, tracked separately. Requiring CI passed needs repository-owner approval and is tracked in herdr-scope-xc7. This PR neither claims nor silently changes branch protection.

All eight hosted checks passed, including Linux tests on the module and stable Go versions, live Herdr integration, both target analyses, workflow/module/format validation, installer/build checks, and the aggregate CI passed gate.

@archae0pteryx
archae0pteryx merged commit dc01966 into master Nov 7, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant