Skip to content

Scope graph thread identity by adapter - #94

Merged
archae0pteryx merged 1 commit into
mainfrom
worktree-native-identity
Nov 13, 2026
Merged

archae0pteryx merged 1 commit into
mainfrom
worktree-native-identity

Conversation

@archae0pteryx

Copy link
Copy Markdown
Contributor

Summary

  • Construct one graph-owned native thread key from adapter and thread at admission.
  • Use that key for record waits, continuation history, reply IDs and open tool calls.
  • Preserve native output IDs, edge names, forwarding behavior and global memory bounds.
  • Document the scope and correct a misleading same-adapter fixture test name.

Verification

  • Four regression tests failed before the fix and passed afterward.
  • Added same-adapter waiting and cross-adapter global-bound checks.
  • Full gate passed: 417 Rust tests plus wrapper and service shell checks, rustfmt and Clippy.

Stack

This is the base PR. A separate PR will target this branch to make exchange ID allocation and queue registration one atomic admission operation. Neither PR should be merged automatically.

@archae0pteryx

Copy link
Copy Markdown
Contributor Author

/review

@github-actions

Copy link
Copy Markdown

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🧪 PR contains tests
🔒 No security concerns identified
⚡ No major issues detected

@coderabbitai

coderabbitai Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Explain Change →

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

Files ignored due to path filters: 1

  • docs/tap-records.md is excluded by none and included by none
Run configuration

Commits

Reviewing files that changed from the base of the PR and between f5ac646 and 261e4cb.

Files ignored due to path filters: 1

  • docs/tap-records.md is excluded by none and included by none

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
Walkthrough

Graph tracking now uses Thread, which combines an adapter name with a native thread ID. Call matching, continuation tracking, and exchange queue placement use this adapter-qualified identity. Exchanges::begin passes the adapter name to Steps::join. Tests cover cross-adapter isolation and same-adapter continuation and ordering behavior.

Merge Risk: Minimal · previous review f5ac6

This change scopes graph thread tracking by adapter so that equal native thread IDs from different adapters no longer interfere with each other. No merge-blocking risk is identified.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@archae0pteryx

Copy link
Copy Markdown
Contributor Author

Stacked follow-up: #95 (atomic exchange admission) targets this branch and contains only the ordering refactor. Review this identity-scoping PR first. After it merges, retarget the follow-up to main and rerun CI. Neither PR is configured for automatic merge.

@archae0pteryx
archae0pteryx added this pull request to stack #96 November 13, 2026 18:48
@archae0pteryx
archae0pteryx force-pushed the worktree-native-identity branch from f5ac646 to 261e4cb Compare November 13, 2026 22:56
@archae0pteryx
archae0pteryx merged commit eb3621d into main Nov 13, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant