Repository navigation
Add Linux service management and real systemd Docker tests - #99
Merged
Merged
Conversation
archae0pteryx
force-pushed
the
worktree-linux-service
branch
from
November 15, 2026 22:53
2c34f8e to
19a369d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
timeout 300 task check </dev/nullpassed on the final tree: 418 Rust tests plus wrapper/service suites under sh, bash, and zsh.timeout 300 task test:systemd </dev/nullpassed: twelve real-systemd tests covering unit validation/enablement, permissions, status, logs, synthetic CONNECT forwarding, reload, restart, crash recovery, update, capture preservation, uninstall/purge, caller-only XDG overrides, and shadowed searched directories.Independent local review
Five findings were fixed: invisible caller-only unit directories, uninstall definition mismatch, shadowed installation identity, mutable Docker image-tag races, and missing-CID cleanup. The final user-authorized scoped verification of install/uninstall identity safety found no issues on
e34e560788d0653a965ec06ad68e428c2a06063cand passed all 19 focused identity mocks. Unrelated Docker/package changes retained prior full local review coverage. No GitHub review bots were invoked.Docker test boundary
The test target requires a trusted rootful Linux Docker daemon with cgroup v2. It runs a privileged container with a private cgroup namespace, no host-directory or Docker-socket mounts, no published ports, and loopback-only runtime networking. Cleanup removes generated captures and CA material. Base images and the Debian package snapshot are pinned. Real-systemd Docker tests remain opt-in, separate from the mocked CI suite.