Repository navigation
feat: add the engineering agent catalog and an interactive installer - #21
Merged
Merged
Conversation
Bundle the 24 engineering agents from agency-agents (MIT) in factory/catalog/, one source file each, and render them per host at install time with model, effort, tools, maxTurns, and Codex sandbox_mode filled in. Read-only agents lose Edit and Write in Claude Code and get a read-only sandbox in Codex. The sources drop the persona, memory, metrics, and advanced-capability sections and the emoji headings, and the eight largest lose most sample code, so the set shrinks from about 315 KB to under 200 KB. install.py run without flags asks for the scope (user-wide or project), the tools, a multi-select of agents, and the catalog models, then confirms before writing. A rerun preselects what is installed. Flags (--scope, --hosts, --agents, --model, --yes) keep the skill and CI non-interactive. Bump the plugin to 2.7.0.
…ering- file prefix Flag runs now add to what is installed; --prune, --remove and the prompts make the folders match the selection. ours() requires a known file name beside the marker, so a user's file that mentions it is spared. Picker applies a/n only when the whole line parses, the tty check counts --hosts, --model and --force, and the Claude name is quoted when needed. Installed files are named by slug, and test_catalog checks the Codex ids agree with build_agents.py.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
factory/catalog/LICENSE) now live infactory/catalog/, one source file each.catalog.pyrenders them per host at install time: Claude Code getsmodel,effort,toolsandmaxTurns; Codex getsmodel,model_reasoning_effortand, for agents that only read,sandbox_mode = "read-only"; Cursor getsreadonly.install.pywith no flags asks for scope (user-wide or project), tools, a multi-select of agents and the catalog models, then confirms before writing.qor end of input writes nothing. A rerun preselects what is installed, and the prompts make the folders match the selection. Flags (--scope,--hosts,--agents,--model,--yes,--remove,--force,--prune) keep the skill and CI non-interactive. A flags run only adds to what is installed;--prunealso removes copies the installer wrote that are not selected. Existing--destbehavior is unchanged.code-reviewer.md,code-reviewer.toml), with no prefix. The installer only treats a file as its own when it carries a marker and has a name it writes, so a user's file that mentions the marker is never deleted, and an existing same-named file is refused unless--force.Tool restrictions
Before, no agent set
tools, so each inherited every tool including all MCP servers. Advisory agents now get noEdit/Write, andincident-response-commanderandnetwork-engineerget noBasheither.Testing
scripts/build_agents.py --check,test_install.py,test_wrap_up.pyandgit diff --checkpass.test_catalog.py(added to CI) covers source validity, rendering for all three hosts, user-wide and project installs, additive runs versus--prune, a user file that mentions the marker surviving a prune, the interactive flow including the empty-tools retry and cancel, refusing to overwrite files the installer did not write, and the lane agents' Codex model ids agreeing with the catalog tiers.Not verified
sandbox_modeset from an agent file. Codex 0.164's config schema accepts the key.Follow-ups are listed under "Engineering catalog" in
tasks/todo.md.