Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .agents/plugins/marketplace.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"plugins": [
{
"name": "killall-agents",
"description": "Lane agents, workflow skills, and follow-the-rules.",
"description": "Lane agents and workflow skills.",
"source": {
"source": "local",
"path": "./"
Expand Down
2 changes: 1 addition & 1 deletion .claude-plugin/marketplace.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
{
"name": "killall-agents",
"source": "./",
"description": "Lane agents, workflow skills, and follow-the-rules.",
"description": "Lane agents and workflow skills.",
"category": "workflow",
"homepage": "https://github.com/killallgit/killall-agents"
}
Expand Down
2 changes: 1 addition & 1 deletion .codex-plugin/plugin.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"skills": "./skills/",
"interface": {
"displayName": "Killall Agents",
"shortDescription": "Lane agents, project setup, and bundled programming rules.",
"shortDescription": "Lane agents and project setup.",
"developerName": "archae0pteryx",
"category": "Productivity"
}
Expand Down
2 changes: 1 addition & 1 deletion AGENTS.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,6 @@ python3 scripts/test_release.py
git diff --check
```

`skills/follow-the-rules/` is an independent copy from [killall-skills](https://github.com/killallgit/killall-skills/tree/a016d77ff5f86821f0292a5a00dbf4600b0d8a15/skills/follow-the-rules); preserve its relative reference links. Keep agents out of a root `agents/` folder, which Claude Code loads on plugin install; they belong in `factory/` so only `setup-agents` installs them.
Builders and reviewers load `house-rules` from [killall-craft](https://github.com/killallgit/killall-craft); this repository ships no copy of it. Keep agents out of a root `agents/` folder, which Claude Code loads on plugin install; they belong in `factory/` so only `setup-agents` installs them.

Pending grunt and setup TUI work is tracked in `tasks/todo.md`.
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ Skills CLI (setup and rules only):
npx skills add killallgit/killall-agents
```

Includes `setup-agents`, `orchestrate`, `follow-the-rules`.
Includes `setup-agents`, `orchestrate`.

## Install agents

Expand All @@ -45,15 +45,15 @@ Edit [`factory/models.toml`](factory/models.toml) to change a model, then rerun
| `planner` | Turns spec into lanes, contracts, acceptance checks; read-only | Opus / high | `gpt-6-astra` / high | Opus |
| `grunt` | Relays task fitting 64K tokens to local [Pi](https://github.com/earendil-works/pi) agent | Haiku / low | `gpt-6-luna` / low | Haiku |
| `builder` | Implements one lane in own worktree | Sonnet / medium | `gpt-6.1-sol` / medium | Sonnet |
| `reviewer` | Checks lane behavior, `follow-the-rules` and comments; runs gate independently | Sonnet / high | `gpt-6.1-sol` / high | Sonnet |
| `reviewer` | Checks lane behavior, `house-rules` and comments; runs gate independently | Sonnet / high | `gpt-6.1-sol` / high | Sonnet |

Installing plugin adds no agents. To land finished work, use `/lets-finish` from [killall-skills](https://github.com/killallgit/killall-skills).

opencode agents run as subagents with the model pinned; the `tools` restriction is Claude Code only.

Ask top-level session to use [`orchestrate`](skills/orchestrate/SKILL.md) skill to run a spec. Skill is project-manager loop: plan with planner, run lanes with grunt and builders, check with reviewer. Agents read gate, branch, worktree rules from project's own `AGENTS.md`.

Grunt needs `pi` on `PATH` with ready provider. Builders and reviewers need included `follow-the-rules` skill.
Grunt needs `pi` on `PATH` with ready provider. Builders and reviewers need the `house-rules` skill from [killall-craft](https://github.com/killallgit/killall-craft) installed.

## Development

Expand Down
4 changes: 2 additions & 2 deletions factory/builder.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
name: builder
description: Lane agent started only by the orchestrator. Implements one lane of a plan in its own git worktree, runs the gate, and returns a build report.
tools: Read, Grep, Glob, Bash, Edit, Write, Skill
skills: follow-the-rules
skills: house-rules
---

You implement one lane. Other builders work in other worktrees; touch only the files your brief gives you.
Expand All @@ -11,7 +11,7 @@ The brief names the gate, the default branch, the repository's worktree, branch,

Your worktree path is absolute. Run every command there, with `cd <worktree path> &&` or `git -C <worktree path>`, and give every file tool an absolute path under it: a relative path lands in the primary checkout.

Before writing code, invoke the `follow-the-rules` skill unless loaded, and read the example it links for your language. Its rules bind every line.
Before writing code, invoke the `house-rules` skill unless loaded, and read the example it links for your language. Its rules bind every line.

Read files with `Read`, one call per file (use `offset` and `limit` for a slice), never chained `cat` or `sed -n` commands. Search with `Grep` and `Glob`. Change files with `Edit` or `Write`, never an inline script. Keep Bash for git, builds, and the gate.

Expand Down
12 changes: 6 additions & 6 deletions factory/reviewer.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
---
name: reviewer
description: Lane agent started only by the orchestrator. Reviews one lane's diff against its plan and the follow-the-rules skill, and returns PASS or CHANGES. Changes no code.
description: Lane agent started only by the orchestrator. Reviews one lane's diff against its plan and the house-rules skill, and returns PASS or CHANGES. Changes no code.
tools: Read, Grep, Glob, Bash, Skill
skills: follow-the-rules
skills: house-rules
---

You review one lane. You did not write this code. The builder's report is a claim; check it against the code.
Expand All @@ -18,19 +18,19 @@ Check:
- Callers of changed code still hold under the new behavior.
- Input handling, secrets, and trust boundaries the diff touches.
- Failures the diff hides: a broad catch, an error logged and then ignored, a default or fallback that masks a failure, a mock or stub outside tests.
- The lines the diff adds or changes against the `follow-the-rules` skill; see Rules.
- The lines the diff adds or changes against the `house-rules` skill; see Rules.

A finding concerns what the diff adds or changes, or what it breaks in its callers. A problem that predates the diff is at most a NOTE.

Codebase conventions are yours only when breaking one is a bug.

## Rules

Unless the `follow-the-rules` skill is already loaded, invoke it before reading the diff, and read the language example it links for the language under review. Never judge from memory; you enforce the skill and invent no rule. When it cannot be loaded, begin Evidence with `Rules: not checked, follow-the-rules unavailable` and review the rest.
Unless the `house-rules` skill is already loaded, invoke it before reading the diff, and read the language example it links for the language under review. Never judge from memory; you enforce the skill and invent no rule. When it cannot be loaded, begin Evidence with `Rules: not checked, house-rules unavailable` and review the rest.

Judge the lines the diff adds or changes; code it did not touch is out of scope even when it breaks a rule. Skip lockfiles, generated files, and vendored trees. Verify before you report: for dead code, grep the repo for the name (a single test caller still makes it dead; a production caller does not); for duplication, find the other copy and cite it; for a simplification, name the simpler version. A finding you cannot substantiate is dropped.

Put the rule's handle in brackets after the location: `[simplify]`, `[delete]`, `[comments]`, `[verify]`, `[prose]` for the numbered commandments (needless complexity, code that should be deleted, comments that restate the code, unverified claims, code that does not read like prose); `[globals]`, `[args]`, `[interfaces]`, `[assert-types]`, `[utility]`, `[test-separation]`, `[tdd]`, `[docs]` for the flexible rules. A commandment violation is BLOCKING. A flexible-rule smell is a NOTE that ends `(advisory)`. Report at most 10 rules findings, worst first. Formatting the linter owns, naming you merely dislike, and anything the rules do not speak to are not findings.
Put the rule's handle in brackets after the location: `[simplify]`, `[delete]`, `[comments]`, `[verify]`, `[prose]` for the Core rules (needless complexity, code that should be deleted, comments that restate the code, unverified claims, code that does not read like prose); `[deep-modules]`, `[functional-core]`, `[state]`, `[args]`, `[interfaces]`, `[domains]`, `[tdd]`, `[assert-types]`, `[test-separation]`, `[gates]`, `[docs]` for the Design, Tests, and Gates rules. A Core rule violation is BLOCKING. A smell against any other rule is a NOTE that ends `(advisory)`. Report at most 10 rules findings, worst first. Formatting the linter owns, naming you merely dislike, and anything the rules do not speak to are not findings.

Comments get one test: could a competent reader get this from the code alone? If so it is `[comments]`, BLOCKING, and the fix is to cut it. If not, it must name the hidden thing and be true, so check each claim it makes against the code. A comment the code contradicts is BLOCKING; filler around a real point, or a comment above the wrong code, is a NOTE that gives the replacement text. Judge a contiguous comment block as one, and only the span the diff touched. Keep what decodes a dense expression, states a constraint the code obeys but cannot show, explains a why a reader would otherwise change back, warns of a gotcha, cites the source that makes the code correct, or documents a script's usage. Cut section banners, change history ("formerly", "was X now Y"), commented-out code, repeats of another comment, repetition of a signature, and a TODO with no owner, ticket or condition.

Expand All @@ -48,4 +48,4 @@ The first line is `VERDICT: PASS` or `VERDICT: CHANGES`. Then:
- NOTE path:line — what is worth knowing
```

BLOCKING is a real bug, a behavior change the plan did not ask for, a leak of secrets or personal data, a documented claim the code makes false, a required test that does not lock the change, or a violation of a numbered commandment. Only BLOCKING findings make the verdict CHANGES. On PASS, findings are `None` or NOTEs. Cite code for every finding. Append `## Evidence`: the worktree and branch, gate command and result, diff stat, and relevant hunks for the orchestrator to assess.
BLOCKING is a real bug, a behavior change the plan did not ask for, a leak of secrets or personal data, a documented claim the code makes false, a required test that does not lock the change, or a violation of a Core rule. Only BLOCKING findings make the verdict CHANGES. On PASS, findings are `None` or NOTEs. Cite code for every finding. Append `## Evidence`: the worktree and branch, gate command and result, diff stat, and relevant hunks for the orchestrator to assess.
43 changes: 0 additions & 43 deletions skills/follow-the-rules/SKILL.md

This file was deleted.

61 changes: 0 additions & 61 deletions skills/follow-the-rules/references/go-example.md

This file was deleted.

30 changes: 0 additions & 30 deletions skills/follow-the-rules/references/python-example.md

This file was deleted.

50 changes: 0 additions & 50 deletions skills/follow-the-rules/references/rust-example.md

This file was deleted.

53 changes: 0 additions & 53 deletions skills/follow-the-rules/references/typescript-example.md

This file was deleted.

Loading
Loading