Skip to content

chore: move follow-the-rules to killall-craft - #37

Merged
archae0pteryx merged 1 commit into
mainfrom
chore/move-rules-to-craft
Nov 10, 2026
Merged

archae0pteryx merged 1 commit into
mainfrom
chore/move-rules-to-craft

Conversation

@archae0pteryx

@archae0pteryx archae0pteryx commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Removes skills/follow-the-rules. The rules now live as house-rules in killall-craft, with the principle skills it routes to (parse-dont-validate, make-the-change-easy, smell-to-refactoring).

  • architectural-review now cites house-rules for its friction signals.
  • .claude-plugin/marketplace.json regenerated with task manifests.

Tests: 131 passed (uv run --python 3.12 --with pytest --with pyyaml pytest).

feat/host-catalogs adds Cursor and GitHub catalogs that still list follow-the-rules; regenerate them after this merges.

Summary by CodeRabbit

  • Documentation
    • Architectural review guidance now references the house-rules lenses from killall-craft, and friction signals are attributed to the house-rules skill.
  • Chores
    • Removed the follow-the-rules plugin listing and its skill from the marketplace configuration.
    • Removed the standalone follow-the-rules guidance and its Go, Python, Rust, and TypeScript examples.

The rules now live as house-rules in killallgit/killall-craft, alongside
the principle skills it routes to. architectural-review cites them there.
@coderabbitai

coderabbitai Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The pull request removes the follow-the-rules skill and its marketplace entries. Architectural review references now identify the house-rules skill in killall-craft.

Changes: Rules skill transition

Layer / File(s) Summary
Remove follow-the-rules from the plugin
.claude-plugin/marketplace.json, skills/follow-the-rules/*
The marketplace entry and skill-list path were removed. The skill guidance and Go, Python, Rust, and TypeScript examples were deleted.
Update architectural review references
README.md, skills/architectural-review/references/vocabulary.md
The architectural review descriptions now refer to the house-rules skill in killall-craft. The vocabulary reference specifies citing it in a candidate’s rules.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Possibly related PRs

  • killallgit/killall-skills#21: Adds manifest generation from skill metadata, which is affected by the removal of follow-the-rules from the skill inventory.
  • killallgit/killall-skills#36: Moves the rules template into follow-the-rules; this pull request removes that skill and refers to house-rules in killall-craft.
Merge Risk: Minimal · up to c3faf

The skill retirement presents no identified merge-blocking risk.

Pre-merge checks: Passed 5

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly describes the main change: moving follow-the-rules to killall-craft.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between e738a5a and c3faf54.

Files selected for processing: 8

  • .claude-plugin/marketplace.json
  • README.md
  • skills/architectural-review/references/vocabulary.md
  • skills/follow-the-rules/SKILL.md
  • skills/follow-the-rules/references/go-example.md
  • skills/follow-the-rules/references/python-example.md
  • skills/follow-the-rules/references/rust-example.md
  • skills/follow-the-rules/references/typescript-example.md
Files with no reviewable changes: 6

  • skills/follow-the-rules/references/typescript-example.md
  • .claude-plugin/marketplace.json
  • skills/follow-the-rules/references/go-example.md
  • skills/follow-the-rules/SKILL.md
  • skills/follow-the-rules/references/rust-example.md
  • skills/follow-the-rules/references/python-example.md

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@archae0pteryx
archae0pteryx merged commit ac86cf4 into main Nov 10, 2026
2 checks passed
@archae0pteryx
archae0pteryx deleted the chore/move-rules-to-craft branch November 10, 2026 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant