Repository navigation
Fail a library or profile skill entry whose local folder no longer holds the skill before installing - #47
Merged
Conversation
… longer holds the named skill.
… pin the all-names and subagent cases.
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Detect missing skills src/app/stale.rs |
Probe gains skill-presence checks. Disk checks for named skills, and source_without_skill identifies local skill sources missing a listed name. Tests cover detection results, including unreadable directories. |
Classify and report missing sources src/app/apply/source_gone.rs, README.md |
SourceGone distinguishes a missing source folder from a folder that lacks the skill and displays a cause-specific message. Tests cover both causes and related entry types. The README describes both failure conditions. |
Priority:
Merge Risk: 
Minimal · up to 3f295
-
Local skill entries are checked before installation. No merge-blocking risk was identified.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bead skillz-ey0. SourceGone now also flags a Spec::Skill whose absolute local source folder exists but no longer holds a named skill, so that entry fails before its install command runs and the others still install. Adds Probe::holds_skill (default true, Disk answers with the harness skill_names_under, the rule npx skills --skill uses) and source_without_skill in stale.rs. A skill-gone folder gets its own advice, since sync only follows a missing folder. Not covered: subagent entries (needs a harness export), dry-run listing, Library stale markers, profile status. Review: independent reviewer PASS, hall-monitor clean after one fix round, gate green, line coverage 92.77%.
Summary by CodeRabbit
npxwhen the source folder exists but no longer contains the requested skill. The error explains that the skill should be restored or the entry updated to point to the correct folder.skillz sync, while a folder without the requested skill receives separate guidance.