Fix SteamID Serialization Improve BanSystem and remove NullReferenceException#88
Open
TheMaxik wants to merge 1 commit into
Open
Fix SteamID Serialization Improve BanSystem and remove NullReferenceException#88TheMaxik wants to merge 1 commit into
TheMaxik wants to merge 1 commit into
Conversation
…x NullReferenceException
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses several issues in the BanSystem:
Fixes SteamID serialization errors by storing SteamID as ulong (SteamID64). issue 75
Implements a join-check in EventHandlers to effectively kick banned players when they connect. (Just for now, until a better system is in place)
Fixes a NullReferenceException when players join before their AuthorizedSteamID is available.