Skip to content

document and tweak remove-invalid-resolved-master-specs! #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
henryw374 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

document and tweak remove-invalid-resolved-master-specs! #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5718dbd
catch any exception when checking master-role? in remove-invalid-reso…
henryw374 Sep 14, 2020
923d8b5
readme - explain the need to call `remove-invalid-resolved-master-spe…
henryw374 Sep 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,10 @@ And Carmine-sentinel subcribes `+switch-master` channel in sentinel.When the mas

At last, carmine-sentinel will refresh the sentinel instance list by the response from command `SENTINEL sentinels [name]`.

In the case where a cached master is not working correctly and the failure has not been detected by the sentinels (for whatever reason) the library will not automatically remove it's cache.

Therefore it is suggested that you call `remove-invalid-resolved-master-specs!` periodically to avoid this situation.

## API docs

* [Carmine-sentinel APIs](http://fnil.net/docs/carmine_sentinel/)
Expand Down
2 changes: 1 addition & 1 deletion src/carmine_sentinel/core.clj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@
(try
(when-not (master-role? (:master master-specs))
(swap! sentinel-resolved-specs dissoc-in [group-id master-name]))
(catch EOFException _
(catch Exception _
(swap! sentinel-resolved-specs dissoc-in [group-id master-name]))))))

(defn register-listener!
Expand Down