Repository navigation
Carry over id_token in refresh_token response - #103
Merged
Merged
Conversation
Authorization servers may omit the id_token in a refresh response (OpenID Connect Core 1.0, section 12.2). Keep the previous id_token so the refreshed bearer stays usable for decode and request_userinfo, matching the existing refresh_token carry-over (RFC 6749, section 10.4). Fixes #100
|
This rules. Thanks. |
Owner
Author
Thanks for reporting this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #100
Client::refresh_tokenalready carried over therefresh_tokenwhen the authorization server omits it from the refresh response (RFC 6749, section 10.4). The same handling is now applied toid_token: OIDC providers (e.g. QuickBooks per the issue) may omit it, and OIDC Core 1.0 section 12.2 explicitly allows the refreshed response to not contain an id_token — the client should then retain the previous one. Without this, the refreshed bearer can no longer be used fordecode_token/request_userinfo.carry_over_missing) so it can be unit-tested without an HTTP runtimeensure_tokenroutes through the same code path, so it is covered too