fix(js-utils): remove webpackIgnore from ExpoSecureStore dynamic import#202
fix(js-utils): remove webpackIgnore from ExpoSecureStore dynamic import#202shafaladhikari wants to merge 2 commits intokinde-oss:mainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughTwo files have been updated to remove webpack-specific Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip CodeRabbit can generate a title for your PR based on the changes with custom instructions.Set the |
Explain your changes
This PR removes the
webpackIgnore: truehint from the dynamic importused to load the Expo secure store implementation.
Problem
The current implementation:
prevents bundlers from resolving the module. While this avoids some
Webpack resolution issues in web environments, it causes problems for
Expo / React Native environments because Metro cannot correctly resolve
and bundle the module.
As a result, the Expo SDK cannot load the secure store implementation at
runtime when upgrading
@kinde/js-utils.Solution
Remove the
webpackIgnorehint so bundlers can resolve the modulenormally:
Validation
Tested with:
This change only removes the webpack hint and does not alter runtime
logic.
Checklist
guidelines.