Skip to content

fix(js-utils): remove webpackIgnore from ExpoSecureStore dynamic import#202

Open
shafaladhikari wants to merge 2 commits intokinde-oss:mainfrom
shafaladhikari:main
Open

fix(js-utils): remove webpackIgnore from ExpoSecureStore dynamic import#202
shafaladhikari wants to merge 2 commits intokinde-oss:mainfrom
shafaladhikari:main

Conversation

@shafaladhikari
Copy link
Copy Markdown

Explain your changes

This PR removes the webpackIgnore: true hint from the dynamic import
used to load the Expo secure store implementation.

Problem

The current implementation:

await import(/* webpackIgnore: true */ "./sessionManager/stores/expoSecureStore.js")

prevents bundlers from resolving the module. While this avoids some
Webpack resolution issues in web environments, it causes problems for
Expo / React Native environments because Metro cannot correctly resolve
and bundle the module.

As a result, the Expo SDK cannot load the secure store implementation at
runtime when upgrading @kinde/js-utils.

Solution

Remove the webpackIgnore hint so bundlers can resolve the module
normally:

await import("./sessionManager/stores/expoSecureStore.js")

Validation

Tested with:

  • Next.js SDK -- build and runtime still work correctly
  • Expo SDK -- secure store module resolves and loads correctly

This change only removes the webpack hint and does not alter runtime
logic.


Checklist

  • I have read the "Pull requests" section in the contributing
    guidelines.
  • I agree to the terms within the code of conduct.

@shafaladhikari shafaladhikari requested a review from a team as a code owner March 14, 2026 10:20
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 14, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e8a96eb5-a7f2-46e2-9a34-5e957bbbafca

📥 Commits

Reviewing files that changed from the base of the PR and between e65adcb and 73a02e0.

📒 Files selected for processing (2)
  • lib/main.ts
  • lib/sessionManager/stores/expoSecureStore.ts

Walkthrough

Two files have been updated to remove webpack-specific webpackIgnore directives from dynamic import statements. The imports now use plain dynamic import syntax. Runtime behavior and return types remain unchanged; only bundler configuration is affected.

Changes

Cohort / File(s) Summary
Webpack Directive Removal
lib/main.ts, lib/sessionManager/stores/expoSecureStore.ts
Removed webpackIgnore: true directives from dynamic import calls. Both files now use standard dynamic import syntax without webpack-specific options. Functional behavior is unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: removing webpackIgnore from the ExpoSecureStore dynamic import, which is the primary purpose of this PR.
Description check ✅ Passed The description is well-structured and directly related to the changeset, explaining the problem, solution, and validation performed for removing the webpackIgnore hint.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can generate a title for your PR based on the changes with custom instructions.

Set the reviews.auto_title_instructions setting to generate a title for your PR based on the changes in the PR with custom instructions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants