Skip to content

fix(ts): follow up TypeScript 6 migration (moduleResolution + explicit types)#210

Open
dtoxvanilla1991 wants to merge 2 commits intokinde-oss:mainfrom
dtoxvanilla1991:fix/ts6-migration-followup
Open

fix(ts): follow up TypeScript 6 migration (moduleResolution + explicit types)#210
dtoxvanilla1991 wants to merge 2 commits intokinde-oss:mainfrom
dtoxvanilla1991:fix/ts6-migration-followup

Conversation

@dtoxvanilla1991
Copy link
Copy Markdown

@dtoxvanilla1991 dtoxvanilla1991 commented Mar 29, 2026

Summary

  • follow up chore(deps): update dependency typescript to v6 #208 TypeScript 6 upgrade with required migration config changes
  • replace deprecated moduleResolution: Node with moduleResolution: Bundler
  • explicitly include ambient types needed by the codebase: node and chrome

Why

TS 6 treats legacy Node module resolution as deprecated and errors during build/typecheck. This caused CI/build risk after the TS 6 version bump.

Validation

  • pnpm build ✔️
  • pnpm exec eslint . ✔️
  • pnpm exec vitest run ✔️

All checks passed locally.

@dtoxvanilla1991 dtoxvanilla1991 requested review from a team as code owners March 29, 2026 22:09
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 29, 2026

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (3)
  • package.json is excluded by !**/*.json
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml, !**/*.yaml
  • tsconfig.json is excluded by !**/*.json

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 9c648346-805c-4af6-a0a5-033d3b885f83

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants