sanctionsai.dev: accessible names for the two site-wide email fields - #2
Open
kindrat86 wants to merge 2 commits into
Open
sanctionsai.dev: accessible names for the two site-wide email fields#2kindrat86 wants to merge 2 commits into
kindrat86 wants to merge 2 commits into
Conversation
sanctionsai.dev/tripwire is live and, unlike the same template on carshake and
sipiteno, is NOT noindex -- so it is indexable and reachable directly.
The only Stripe link anywhere in api.py was the literal placeholder
buy.stripe.com/REPLACE_WITH_TRIPWIRE_LINK, so the page had no working checkout
at all. On top of that it carried:
- "One-time payment. Instant access." -- clicking went nowhere
- a "60-Day Guarantee ... I will refund your $7" on an impossible purchase
- a testimonial from "Agent Framework Author, San Francisco" describing use of
a kit nobody has ever been able to buy
The testimonial is removed on the same basis as carshake's: when a review
describes purchasing a product whose checkout is a placeholder, it is provably
fabricated, not merely unverified.
The CTA now points at hello@sanctionsai.dev, which is a route that actually
works, and says plainly that checkout is not automated. Creating a Stripe
payment link is a financial action and is left to the owner.
Verified the removed <div class="quote"> was the only one in the file, so the
single-match regex could not have hit anything else in this 836KB module.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The footer subscribe form appears on 6 of the 7 audited pages. Its action and method were already correct — it submits natively — but the field's only description was a placeholder, so a screen reader announced an unnamed required edit box and an agent had nothing to key on. Same for the optional email box on the wallet-checker tool, which additionally had no name. The free-tier capture form on the home page relies on JS and had neither a name on its field nor a method on the form; a named field in a form with no method submits over GET, putting the address in the URL. Audited against a local run of this server, before and after, with the same engine on both sides: 41 findings -> 38, gate FAIL -> PASS, and E3/E4/F1 (no label, no autocomplete, empty accessible name) 6 -> 0 each. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fourth site in the portfolio DOM and agent-readability pass. Do not merge without review.
What this fixes
The footer subscribe form appears on 6 of the 7 audited pages. Its
actionandmethodwere already correct — it submits natively, which is the more robust pattern — but the field's only description was a placeholder. A screen reader announced an unnamed required edit box; an agent had nothing to key on.The same applied to the optional email box on the wallet-checker tool, which additionally had no
name.The free-tier capture form on the home page relies on JS and had neither a
nameon its field nor amethodon the form — so a JS failure would submit over GET and put the address in the URL.Three edits, all attribute additions inside the HTML strings in
api.py. No copy, layout or route changed.api.pystill parses.Measured
Audited against a local run of this exact server (
python -m agentmail.apion 127.0.0.1), before and after, with the same engine version on both sides:nameserverTextRatiowas never a problem here — worst page 0.988.Running it locally needs Python 3.10+ (
str | Noneinagentmail/sms/__init__.pyfails on 3.9) but no third-party packages: the server is stdlibhttp.server.Deliberately NOT changed
<main>/<header>landmarks, 14 findings — the largest remaining item, same template-level issue as every other site in this pass.aria-describedby, 7 findings — needs a status element per form to point at.color-contrastandregion— brand colour and template changes.While this work was in progress, Fly release v373 completed roughly 30 seconds after
api.pywas last written, and production picked up an uncommitted edit — the exact attribute order from the first edit batch appeared live on sanctionsai.dev. Releases before it ran roughly every two hours, all assales@sipiteno.com.That means an unreviewed change reached production without going through this PR. Nothing here was intended to ship before review.
The working tree has been returned to
main, so the next automatic deploy serves the pre-change state again, and all of this work lives only on this branch. Whatever is deploying~/workspace/agentmailshould be pointed at a commit rather than the working tree — the portfolio already has~/growth-loop/lib/deploy_from_commit.shfor exactly this failure mode.🤖 Generated with Claude Code