Repository navigation
feat!: rename filled Material Symbols suffix to Fill - #43
Conversation
There was a problem hiding this comment.
Code Review
This pull request bumps the SymbolCraft version to 0.5.0 and introduces a breaking change where generated filled Material Symbols use 'Fill' in their Kotlin names instead of 'fill1' (which is still used internally for the Google Fonts download URL). It updates the documentation in both English and Chinese READMEs, updates the example application to use the new names, and adds unit tests to verify the URL suffix and signature generation. There are no review comments to address, and the changes look clean and well-tested.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
Documentation Updates 2 document(s) were updated by changes in this PR: Style Parameter Builder SyntaxView Changes@@ -14,7 +14,7 @@
```kotlin
styleParam("fill") {
- values("", "fill1") // unfilled, filled variants
+ values("", "-fill") // unfilled, filled variants
}
```
@@ -41,7 +41,7 @@
values("24", "48")
}
styleParam("fill") {
- values("", "fill1")
+ values("", "-fill")
}
```
@@ -52,7 +52,7 @@
```kotlin
styleParam("size", "24") // fixed size
styleParam("fill") {
- values("", "fill1")
+ values("", "-fill")
}
```
URL Template SystemView Changes@@ -33,14 +33,14 @@
```kotlin
externalIcon("home", libraryName = "official") {
- urlTemplate = "https://example.com/{name}_{fill}_24px.svg"
+ urlTemplate = "https://esm.sh/@material-symbols/svg-400@latest/rounded/{name}{fill}.svg"
styleParam("fill") {
- values("", "fill1") // unfilled and filled variants
+ values("", "-fill") // unfilled and filled variants
}
}
```
-This configuration generates two icon variants: one with `fill` as an empty string and one with `fill` as `"fill1"`, resulting in URLs like `https://example.com/home__24px.svg` and `https://example.com/home_fill1_24px.svg` respectively. The builder handles the expansion automatically by computing the Cartesian product of all multi-value parameters and combining them with any single-value parameters. This logic is implemented in the builder's `cartesianProduct` method, which folds over the parameter map entries to produce all possible key-value combinations.
+This configuration generates two icon variants: one with `fill` as an empty string and one with `fill` as `"-fill"`, resulting in URLs like `https://esm.sh/@material-symbols/svg-400@latest/rounded/home.svg` and `https://esm.sh/@material-symbols/svg-400@latest/rounded/home-fill.svg` respectively. The builder handles the expansion automatically by computing the Cartesian product of all multi-value parameters and combining them with any single-value parameters. This logic is implemented in the builder's `cartesianProduct` method, which folds over the parameter map entries to produce all possible key-value combinations.
### Single URL Template Approach and Code Duplication Reduction
|
No description provided.