Open
Conversation
shabaraba
commented
Mar 2, 2026
e2e-tests/bin/run-test.sh
Outdated
| # KINTONE_BASE_URL - テストに使うkintoneのURL | ||
| # KINTONE_DEFAULT_USER / KINTONE_DEFAULT_PASSWORD - デフォルトユーザー認証情報 | ||
| # KINTONE_TEST_USER / KINTONE_TEST_PASSWORD - テストユーザー認証情報 | ||
| # KINTONE_SPACE_ID 等 - 詳細は .env.example を参照 |
There was a problem hiding this comment.
Pull request overview
Sets up initial CI scaffolding for running end-to-end (E2E) tests for this Java client on GitHub Actions by introducing a dedicated e2e-tests/ Gradle project and an Actions workflow to execute it.
Changes:
- Added a new GitHub Actions workflow to run E2E tests on push/PR to
masterand via manual dispatch (with optional test-class filtering). - Introduced a standalone
e2e-tests/Gradle project (including its own Gradle wrapper) plus helper scripts to build/copy the client jar and run tests. - Added a placeholder JUnit test to validate the workflow wiring.
Reviewed changes
Copilot reviewed 8 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/e2e.yml |
Adds an Actions workflow to run the E2E test project and optionally filter to a specific test class. |
e2e-tests/src/test/java/com/kintone/client/DummyTest.java |
Adds a placeholder JUnit test to validate CI execution. |
e2e-tests/build.gradle |
Defines dependencies and test configuration for the E2E Gradle project. |
e2e-tests/settings.gradle |
Declares the E2E project name. |
e2e-tests/bin/run-test.sh |
Script to build the client jar and execute E2E tests. |
e2e-tests/bin/update-client-jar.sh |
Script intended to rebuild/copy the client jar for E2E usage. |
e2e-tests/.gitignore |
Ignores local env/jar artifacts and Gradle build outputs for the E2E project. |
e2e-tests/gradlew |
Adds Gradle wrapper script for the E2E project. |
e2e-tests/gradlew.bat |
Adds Gradle wrapper script for Windows for the E2E project. |
e2e-tests/gradle/wrapper/gradle-wrapper.properties |
Pins the Gradle distribution used by the E2E project wrapper. |
e2e-tests/gradle/wrapper/gradle-wrapper.jar |
Adds the Gradle wrapper jar for the E2E project. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
nameless-mc
reviewed
Mar 2, 2026
e2e-tests/bin/run-test.sh
Outdated
Comment on lines
+32
to
+33
| BASE_DIR=$(cd "$(dirname "$0")"/../; pwd) | ||
| CLIENT_DIR=$(cd "$BASE_DIR"/.. ; pwd) |
Contributor
There was a problem hiding this comment.
BASE_DIR/CLIENT_DIRがちょっと分かりづらい気がする
E2E_ROOT_DIR/REPOSITORY_ROOT_DIR とか?
shabaraba
force-pushed
the
ci/e2e-workflow
branch
from
a6c4f37 to
baa67b7
Compare
nameless-mc
reviewed
Mar 4, 2026
| @@ -0,0 +1,51 @@ | |||
| name: E2E Tests | |||
Contributor
There was a problem hiding this comment.
concurrency の設定を入れておいた方が良さそう
Comment on lines
+1
to
+10
| .gradle/ | ||
| build/ | ||
| # bin/ is used for scripts, not Eclipse build output | ||
| !bin/ | ||
| bin/test/ | ||
| .env | ||
| kintone-java-client.jar | ||
| .classpath | ||
| .project | ||
| .settings/ |
Contributor
There was a problem hiding this comment.
不要になったものが何個かありそう
!binとかkintone-java-client.jarとか
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Set up CI infrastructure to enable automated E2E testing of kintone-java-client on GitHub Actions.
What
e2e.yml)masterand manual dispatchworkflow_dispatchparametere2e-tests/)bin/run-test.sh: Builds client → copies JAR → runs testsbin/update-client-jar.sh: Utility to update JAR onlyDummyTest.java) to verify workflow executionHow to test
Run locally:
cd e2e-tests ./bin/run-test.shCI workflow verification requires merge and configured Secrets.
Checklist