Skip to content
This repository was archived by the owner on Jun 29, 2022. It is now read-only.

Rename Packet to Equinix Metal in docs - #1409

Open
Maartje Eyskens (meyskens) wants to merge 1 commit into
kinvolk:masterfrom
meyskens:meyskens/packet-rename
Open

Maartje Eyskens (meyskens) wants to merge 1 commit into
kinvolk:masterfrom
meyskens:meyskens/packet-rename

Conversation

@meyskens

Copy link
Copy Markdown
Contributor

Rename Packet to Equinix Metal in docs

Renames Packet to Equinix Metal in the readme and quickstart, I did not change the file names as not to break links. If you also want to have that done happy to add redirects.

How to use

Read the documentation ;)

Testing done

None

Notes

Sorry still used my fork, pushed it before i realized i forgot to change back the Git remote.

@meyskens

Copy link
Copy Markdown
Contributor Author

A conflict... that will learn me to not update my remote ;)

Comment thread docs/quickstarts/packet.md Outdated
Comment thread docs/quickstarts/packet.md Outdated
Comment thread docs/quickstarts/packet.md
@meyskens

Copy link
Copy Markdown
Contributor Author

Fixed the feedback, ready for review again!

@surajssd Suraj Deshmukh (surajssd) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃憤

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change other mentions of Packet? I see some links in how-to-guides/ingress-with-contour-metallb.md, how-to-guides/rook-ceph-storage.md, configuration-reference/components/metallb.md, concepts/packet.md.

I think changing file names (e.g. packet.md) can be done later when we change cluster "packet" to cluster "equinix_metal" or similar.

Otherwise can you include all changes in one commit?

@meyskens

Copy link
Copy Markdown
Contributor Author

Iago L贸pez Galeiras (@iaguis) finetined my search and found even more 馃槄 All changed now

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found some more with an awesome command:

> ag Packet | grep -v Equinix | awk -F: '{print $1}' | uniq
configuration-reference/platforms/packet.md
configuration-reference/components/prometheus-operator.md
quickstarts/packet.md
how-to-guides/setup-thirdparty-auth-for-grafana.md
how-to-guides/backup-rook-ceph-volumes.md
how-to-guides/monitoring-with-prometheus-operator.md
concepts/dns.md
concepts/securing-lokomotive-cluster.md

Comment thread docs/how-to-guides/rook-ceph-storage.md
Comment thread docs/how-to-guides/ingress-with-contour-metallb.md
@surajssd

Copy link
Copy Markdown
Contributor

Another thing about changing file names is broken links. So maybe we can keep the old pages around for a while with redirects to new docs and then remove it after couple of releases.

@meyskens

Copy link
Copy Markdown
Contributor Author

Time for more changes :) do not review for a while ;)

Signed-off-by: Maartje Eyskens <maartje@kinvolk.io>
@meyskens

Copy link
Copy Markdown
Contributor Author

Should have catched them all by now :) Let me know if you find some more!

@surajssd

Copy link
Copy Markdown
Contributor

Iago L贸pez Galeiras (@iaguis) PTAL.

@ipochi

Copy link
Copy Markdown
Member

A lot of it has been changed. I think this can be closed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants