Skip to content

fix: drain wp db import stdout to prevent restore deadlock #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kjellberg merged 1 commit into from
Jun 7, 2026
Merged

fix: drain wp db import stdout to prevent restore deadlock #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/commands/db/restore.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,10 @@ async function runRestore(
const child = spawnWpCli(composePath, ['wp', 'db', 'import', '-']);
const stderrChunks: Buffer[] = [];
child.stderr.on('data', (c: Buffer) => stderrChunks.push(c));
// Drain stdout. We don't use its content (errors come from stderr), but if
// the child writes more than the OS pipe buffer (~64KB) and nothing reads
// it, the child blocks on write and the import deadlocks.
child.stdout.resume();
const src = storage.openRead(record).pipe(createGunzip());
src.pipe(child.stdin);
await new Promise<void>((resolve, reject) => {
Expand Down
Loading