Skip to content

[Enhancement] Add medium size and badge support to chipped segmented control #4672

Description

@jwtjwtjwt

Describe the enhancement

I would like the chipped mode of the segmented control component to offer the same size and badge options as the default mode. Currently, chipped mode does not include the md size or an option to display badges on chips.

Describe the solution you'd like

Add the md size and badge option to chipped segmented controls in both Figma and code so the available configuration mirrors the default mode.

Have you considered any alternatives?

No alternatives have been identified.

Are there any additional context?

The difference can be observed by placing default and chipped segmented control components next to each other in Figma and comparing their options. A developer has confirmed that the same difference exists in code.

Kirby version: Current version at the time of reporting.

Comparison of default and chipped segmented control options

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Refinement

  • Request that the issue is UX refined
  • Request that the issue is tech refined; do not proceed until this is done.

Implementation

The contributor who wants to implement this issue should:

  • Make sure you have read: "Before you get coding".
  • Signal to others you are working on the issue by assigning yourself.
  • Create a branch from the develop branch following our branch naming convention.
  • Publish a WIP implementation to GitHub as a draft PR and ask for feedback.
  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Update the cookbook with examples and showcases.

Review

Once the issue has been implemented and is ready for review:

  • Do a self-review.
  • Create a pull request. If you created a draft PR during implementation, you can mark that as "ready for review".

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    • Status
      🏗️ Todo

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions