Skip to content

Design Tokens: add design token pipeline (@repo/design-tokens) - #4745

Open
RasmusKjeldgaard wants to merge 7 commits into
developfrom
enhancement/design-token-pipeline-generator
Open

RasmusKjeldgaard wants to merge 7 commits into
developfrom
enhancement/design-token-pipeline-generator

Conversation

@RasmusKjeldgaard

@RasmusKjeldgaard RasmusKjeldgaard commented Sep 29, 2026 •

Copy link
Copy Markdown
Collaborator

Which issue does this PR close?

This PR closes #4684

What is the new behavior?

This PR adds a pipeline that takes Figma Extended Collections and turns them into CSS Custom Properties that can be consumed by code.

More details can be found in the library README.md.

The generated CSS files are not added here, but in a follow-up PR here: #4749

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any additional context?

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Reminders

  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).

Review

  • Determine if your changes are a fix, feature or breaking-change, and add the matching label to your PR. If it is tooling, dependency updates or similar, add ignore-for-release.
  • Do a self-review.
  • Request that the changes are code-reviewed
  • Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)

When the pull request has been approved it will be merged to develop by Team Kirby.


Stack created with GitHub Stacks CLI • Give Feedback 💬

@RasmusKjeldgaard
RasmusKjeldgaard added this pull request to stack #4746 September 29, 2026 13:48
@github-actions
github-actions Bot had a problem deploying to pr-design-token-pipeline-generator September 29, 2026 13:51 Failure
@RasmusKjeldgaard
RasmusKjeldgaard removed this pull request from stack #4746 September 29, 2026 19:50
@RasmusKjeldgaard
RasmusKjeldgaard force-pushed the enhancement/design-token-pipeline-generator branch from 9ba9ffc to 76e0b43 Compare September 29, 2026 19:53
@RasmusKjeldgaard
RasmusKjeldgaard added this pull request to stack #4748 September 29, 2026 19:53
@RasmusKjeldgaard
RasmusKjeldgaard force-pushed the enhancement/design-token-pipeline-generator branch from 76e0b43 to f340ec7 Compare September 29, 2026 20:17
@RasmusKjeldgaard
RasmusKjeldgaard force-pushed the enhancement/design-token-pipeline-generator branch from f340ec7 to 4b5a636 Compare October 1, 2026 10:07
@RasmusKjeldgaard
RasmusKjeldgaard force-pushed the enhancement/design-token-pipeline-generator branch from 4675dfc to 1ae0401 Compare October 1, 2026 12:17
@RasmusKjeldgaard RasmusKjeldgaard added the ignore-for-release Housekeeping, tooling etc. that have no relevance for consumers of Kirby label Oct 1, 2026
@RasmusKjeldgaard
RasmusKjeldgaard marked this pull request as ready for review October 1, 2026 14:10
@RasmusKjeldgaard
RasmusKjeldgaard force-pushed the enhancement/design-token-pipeline-generator branch from 079344e to f01356a Compare October 5, 2026 13:59
@github-actions
github-actions Bot had a problem deploying to pr-design-token-pipeline-generator October 5, 2026 14:03 Failure
Base automatically changed from enhancement/design-token-pipeline-docs to develop October 5, 2026 14:08
@RasmusKjeldgaard
RasmusKjeldgaard force-pushed the enhancement/design-token-pipeline-generator branch from f01356a to 38ad346 Compare October 5, 2026 14:08
@RasmusKjeldgaard
RasmusKjeldgaard force-pushed the enhancement/design-token-pipeline-generator branch 2 times, most recently from 5e1f058 to 75d0695 Compare October 6, 2026 13:41
martinkolle
martinkolle previously approved these changes Oct 8, 2026

@martinkolle martinkolle left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! For the future we could consider using a package for the figma conversion - I looked shortly at @bonniernews/figma-variables-import but we should consider if it stays updated by Bonnier

Loujuu
Loujuu previously approved these changes Oct 8, 2026
@RasmusKjeldgaard

RasmusKjeldgaard commented Oct 8, 2026 •

Copy link
Copy Markdown
Collaborator Author

Looks good! For the future we could consider using a package for the figma conversion - I looked shortly at @bonniernews/figma-variables-import but we should consider if it stays updated by Bonnier

I agree! This whole pipeline exists because I was unable to find an open source alternative that supports Extended Collections in Figma, and most existing solutions seem to need quite a lot of glue code to be able to support our surface model, in a scalable multi-brand way.

So I figured we write our own for now, to not have to battle with the assumptions that other similar pipelines have.

@martinkolle martinkolle left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good refactor

This branch was successfully deployed

1 active deployment
pr-design-token-pipeline-generator — c98a552c Deployed Oct 9, 2026 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ignore-for-release Housekeeping, tooling etc. that have no relevance for consumers of Kirby

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Housekeeping] Add design tokens figma pipeline

3 participants