Repository navigation
More tests for the God of Tests! - #10
Merged
Merged
Conversation
16 new tests covering previously untested claims and guarantees, organized by test level for maximum efficiency
There was a problem hiding this comment.
Pull request overview
Adds additional unit/integration/E2E coverage for crypto, wire-format, stego, identity backup guarantees, plus a CI guardrail for bundle size.
Changes:
- Add unit tests for crypto properties (ECDH symmetry/deniability framing, MSG anonymity, seed freshness), wire CONTACT non-authentication, and XEdDSA public verifiability.
- Expand stego tests (non-determinism, trim tolerance, null detection on non-encoded text) and property-based safety checks (no invisible/combining chars; compression non-expansion).
- Add E2E coverage for unknown-sender handling and self-encryption roundtrip; document the test layers; add a CI bundle-size threshold.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/unit/wire.test.ts | Adds a security-property test clarifying CONTACT check bytes are not authentication. |
| tests/unit/stego.test.ts | Adds tests around stego variability, whitespace tolerance, and rejecting non-encoded text. |
| tests/unit/sign.test.ts | Adds a test asserting third-party verifiability of broadcast signatures. |
| tests/unit/properties.test.ts | Adds property tests for stego output character safety and compression non-expansion. |
| tests/unit/identity.test.ts | Adds a test attempting to pin PBKDF2 iteration count. |
| tests/unit/crypto.test.ts | Adds tests for ECDH shared-secret symmetry, MSG anonymity, and seed freshness. |
| tests/unit/broadcast.test.ts | Adds a test for 3+ candidate fingerprint collision handling. |
| tests/integration/broadcast-pipeline.test.ts | Adds an integration test validating broadcast tail layout prevents repeatable leading bytes. |
| tests/e2e/conversation.spec.ts | Adds an E2E test for “unknown sender INTRO not committed to chat until saved”. |
| tests/e2e/basic.spec.ts | Adds an E2E self-encryption encode→decode roundtrip test. |
| docs/testing.md | Updates testing documentation to mention the new guarantees/tests and CI behavior. |
| .github/workflows/ci.yml | Adds a CI step to fail if dist/index.html exceeds 40KB. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Deploying paternoster with
|
| Latest commit: |
9537842
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://87b6de06.paternoster.pages.dev |
| Branch Preview URL: | https://kirushik-more-tests.paternoster.pages.dev |
kirushik
force-pushed
the
kirushik/more_tests
branch
from
March 30, 2026 16:36
91c84ed to
9537842
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
16 new tests covering previously untested claims and guarantees, organized by test level for maximum efficiency