Skip to content

More tests for the God of Tests! - #10

Merged
kirushik merged 2 commits into
mainfrom
kirushik/more_tests
Mar 30, 2026
Merged

kirushik merged 2 commits into
mainfrom
kirushik/more_tests

Conversation

@kirushik

Copy link
Copy Markdown
Owner

16 new tests covering previously untested claims and guarantees, organized by test level for maximum efficiency

16 new tests covering previously untested claims and guarantees, organized by test level for maximum efficiency
Copilot AI review requested due to automatic review settings March 30, 2026 15:15

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds additional unit/integration/E2E coverage for crypto, wire-format, stego, identity backup guarantees, plus a CI guardrail for bundle size.

Changes:

  • Add unit tests for crypto properties (ECDH symmetry/deniability framing, MSG anonymity, seed freshness), wire CONTACT non-authentication, and XEdDSA public verifiability.
  • Expand stego tests (non-determinism, trim tolerance, null detection on non-encoded text) and property-based safety checks (no invisible/combining chars; compression non-expansion).
  • Add E2E coverage for unknown-sender handling and self-encryption roundtrip; document the test layers; add a CI bundle-size threshold.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
tests/unit/wire.test.ts Adds a security-property test clarifying CONTACT check bytes are not authentication.
tests/unit/stego.test.ts Adds tests around stego variability, whitespace tolerance, and rejecting non-encoded text.
tests/unit/sign.test.ts Adds a test asserting third-party verifiability of broadcast signatures.
tests/unit/properties.test.ts Adds property tests for stego output character safety and compression non-expansion.
tests/unit/identity.test.ts Adds a test attempting to pin PBKDF2 iteration count.
tests/unit/crypto.test.ts Adds tests for ECDH shared-secret symmetry, MSG anonymity, and seed freshness.
tests/unit/broadcast.test.ts Adds a test for 3+ candidate fingerprint collision handling.
tests/integration/broadcast-pipeline.test.ts Adds an integration test validating broadcast tail layout prevents repeatable leading bytes.
tests/e2e/conversation.spec.ts Adds an E2E test for “unknown sender INTRO not committed to chat until saved”.
tests/e2e/basic.spec.ts Adds an E2E self-encryption encode→decode roundtrip test.
docs/testing.md Updates testing documentation to mention the new guarantees/tests and CI behavior.
.github/workflows/ci.yml Adds a CI step to fail if dist/index.html exceeds 40KB.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tests/unit/identity.test.ts Resolved
Comment thread tests/unit/broadcast.test.ts Resolved
Comment thread tests/unit/stego.test.ts Resolved
Comment thread docs/testing.md Resolved
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Mar 30, 2026 •

Copy link
Copy Markdown

Deploying paternoster with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9537842
Status: ✅  Deploy successful!
Preview URL: https://87b6de06.paternoster.pages.dev
Branch Preview URL: https://kirushik-more-tests.paternoster.pages.dev

View logs

@kirushik
kirushik force-pushed the kirushik/more_tests branch from 91c84ed to 9537842 Compare March 30, 2026 16:36
@kirushik
kirushik merged commit 2450fd8 into main Mar 30, 2026
4 checks passed
@kirushik
kirushik deleted the kirushik/more_tests branch March 30, 2026 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants