Repository navigation
Restore the Python 3.10 test floor and credit contributors - #2
Merged
Merged
Conversation
TestCase.enterContext landed in 3.11, so the nine new source-checker tests errored out with AttributeError on 3.10. CI pins 3.12 and stayed green, which hid the raised floor. Swap in start()/addCleanup, which behaves identically and works everywhere. Follow-up to the source-checker tests WhiteHades contributed in #1; the tests and the behaviour they cover are theirs, this only lowers the interpreter floor back to 3.10. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018rw2KxMtReyjCJDwrgVtZR
Add an acknowledgements section naming WhiteHades for the search, accessibility, route, source, and validation fixes in #1, so the credit survives however the pull request is merged. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018rw2KxMtReyjCJDwrgVtZR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two follow-ups to #1, which is now merged.
Keep the source-checker tests runnable on Python 3.10.
TestCase.enterContextlanded in 3.11, so the nine new source-checker tests errored out withAttributeErroron 3.10. CI pins 3.12 and stayed green, which hid the raised floor. Swapped instart()/addCleanup, which behaves identically and works everywhere.Credit contributors in the README. New acknowledgements section naming @WhiteHades for the search, accessibility, route, source, and validation fixes in #1, so the credit is durable in the repo rather than only in commit metadata.
Verified on both interpreters:
scripts/validate.pypython -m unittest discover -s tests(3.10)python -m unittest discover -s tests(3.12)node tests/test_site_search.js🤖 Generated with Claude Code
https://claude.ai/code/session_018rw2KxMtReyjCJDwrgVtZR