Refactor/sort#28
Merged
Merged
Conversation
Added multicolumn sorting to enable tie breakers and nil value sorting to push nil valued rows to the last row of the dataframe
The multiple columns test will test to see if the multi column logic works where if 2 values are the same, then look at the second column to tie break. The nil value test is to test the nil value handling logic where we push the nil value'd row to the end of the dataframe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sort method refactorization
sortValuesmethod to handle multiple columns, used for tie breaking columns.sortValuesmethod to handle Nil value scenarios.Example Syntax:
where colNames is the slice of columns to sort by.
Important things to note**
#26