Repository navigation
test: make expired connection identity fixture deterministic - #66
Merged
Merged
Conversation
Owner
Author
|
Independent implementation review completed on exact head Focused integration tests (9/9), typecheck, file lint and diff validation passed. Full CI #43330407101 is queued. Merge remains conditional on successful CI and no unresolved review threads. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The exact-main Validation run #43328724973 failed while preparing the expired persisted connection in
connection-identity.test.ts. Updating onlyexpires_atto the current time minus one millisecond can violate SQLite'sexpires_at > created_atconstraint when connection creation and fixture setup occur in the same millisecond. The rejection assertion is then never reached.Changes
Backdate
created_atandexpires_attogether using one captured timestamp, so the retained grant has a valid historical lifetime and is already expired. Preserve the real GuestDO/SQLite setup, object eviction, and the assertion that authenticated connection inspection returnsnull.Only the test fixture changes. Runtime code, schema constraints, and acceptance expectations are unchanged; no sleeps or retries are added.
Validation
git diff --check: passed.4397c39d21dbc2e4dfa3fe48523d937d6b001332.Refs #24 and #65. The actual-host pilot in draft PR #63 remains unverified; this fixture correction supplies no event/run/reply evidence.