Skip to content

test: make expired connection identity fixture deterministic - #66

Merged
kitamura-tetsuo merged 1 commit into
mainfrom
fix/connection-expiry-fixture
Nov 12, 2026
Merged

kitamura-tetsuo merged 1 commit into
mainfrom
fix/connection-expiry-fixture

Conversation

@kitamura-tetsuo

@kitamura-tetsuo kitamura-tetsuo commented Nov 12, 2026 •

Copy link
Copy Markdown
Owner

Why

The exact-main Validation run #43328724973 failed while preparing the expired persisted connection in connection-identity.test.ts. Updating only expires_at to the current time minus one millisecond can violate SQLite's expires_at > created_at constraint when connection creation and fixture setup occur in the same millisecond. The rejection assertion is then never reached.

Changes

Backdate created_at and expires_at together using one captured timestamp, so the retained grant has a valid historical lifetime and is already expired. Preserve the real GuestDO/SQLite setup, object eviction, and the assertion that authenticated connection inspection returns null.

Only the test fixture changes. Runtime code, schema constraints, and acceptance expectations are unchanged; no sleeps or retries are added.

Validation

  • Focused connection-identity integration suite: 9/9 passed.
  • TypeScript typecheck, file lint, and git diff --check: passed.
  • Full GitHub Validation #43330407101: all 28 steps passed on exact head 4397c39d21dbc2e4dfa3fe48523d937d6b001332.
  • Independent implementation review found no actionable issue. Fresh GitHub review/thread readback found no reviews or unresolved threads before merge.

Refs #24 and #65. The actual-host pilot in draft PR #63 remains unverified; this fixture correction supplies no event/run/reply evidence.

Copy link
Copy Markdown
Owner Author

Independent implementation review completed on exact head 4397c39d21dbc2e4dfa3fe48523d937d6b001332: no actionable finding. The atomic historical timestamp update preserves expires_at > created_at; real GuestDO creation, retained SQLite state, eviction and the public null rejection oracle are unchanged. As before, alarm cleanup may cause an expired row to be rejected as missing; the test verifies nondisclosure, not a particular internal error code.

Focused integration tests (9/9), typecheck, file lint and diff validation passed. Full CI #43330407101 is queued. Merge remains conditional on successful CI and no unresolved review threads.

@kitamura-tetsuo
kitamura-tetsuo merged commit e04cd3b into main Nov 12, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant