Repository navigation
Add English UI; keep Japanese for ja* browsers - #3
Merged
Merged
Conversation
Switch popup, injected controls, errors, and manifest name/description by browser language (chrome.i18n.getUILanguage, then navigator.language). ja* stays Japanese; every other tag falls back to English. Store listing copy and screenshot overlays now have an English set in the repo. Live Chrome Web Store is not changed from this change. Co-authored-by: Quo / クオ <quolu@users.noreply.github.com>
cursor
Bot
force-pushed
the
cursor/english-locale-3c78
branch
from
August 24, 2026 23:57
70ed8e1 to
f1098f6
Compare
quolu
marked this pull request as ready for review
August 24, 2026 23:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The shipped UI was Japanese-only. Real installs are not Japan-only. This change ships English now and keeps Japanese. Later locales only need a new catalog.
Rebased onto current
mainafter #2 (公開表記をChrome Web Store一般公開済みに揃える). English UI and English listing assets are kept. Japanese remains forja*.Locale contract
Documented in
docs/adr/0001-ui-locale.md(2026-08-24 JST):chrome.i18n.getUILanguage(), thennavigator.languagejaandja-*→ Japanesedefault_localeisenRuntime lookup is
src/i18n.js(CB_I18N)._locales/{en,ja}/messages.jsonhold the three Chrome name/description/title keys and must match the runtime catalog.Product surfaces
User-visible strings now go through that helper:
data-i18n, dynamic rows/toasts in JS)Adapter
entityLabeltokens stay as they are (ショップ,出品者,チャンネル). Display text is translated at the edge.Store listing (repo only)
English listing copy is in
docs/store/listing.md. English screenshots and the small promo are inassets/store/en/. Japanese listing assets stay inassets/store/.v2.0.1 is already generally available. Updating these docs does not resubmit the live store. This PR does not scrape or submit to the live Chrome Web Store. It does not add a marquee or a wide promotional image. It does not apply a store-highlight treatment.
AliExpress host chrome in screenshots 01, 02, and 04 is still the 2026-08-15 Japanese page capture. Automated recapture of that site is blocked. Caption overlays and the English popup/promo/surfaces cards are new.
Docs
Tests
node --test test/*.test.mjs test/adapters/*.test.mjs— 256 pass after the rebase.New
test/i18n.test.mjscovers locale selection and that every English string exists. Existing UI tests pinjaso the Japanese wording stays checked.Out of scope