Skip to content

Add new p4a opts#2010

Draft
T-Dynamos wants to merge 1 commit intokivy:masterfrom
T-Dynamos:new_opts
Draft

Add new p4a opts#2010
T-Dynamos wants to merge 1 commit intokivy:masterfrom
T-Dynamos:new_opts

Conversation

@T-Dynamos
Copy link
Copy Markdown
Member

Copy link
Copy Markdown
Contributor

@kuzeyron kuzeyron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one suggestion.

self.extra_p4a_args.append("--debug")

save_wheel_dir = self.buildozer.config.getdefault('app', "p4a.save_wheel_dir", "")
if save_wheel_dir != "":
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!= "" is not needed. Just use if save_wheel_dir:

Comment thread buildozer/default.spec
# These indexes are searched in addition to the default PyPI index during Android builds.
# WARNING: Third party indexes are untrusted sources and may introduce supply chain risks,
# including malicious, tampered, outdated, or incompatible packages.
extra_index_urls = https://chaquo.com/pypi-13.1/, https://anshdadwal.is-a.dev/p4a-wheels/p4a/
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these trusted?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's not my decision, I think it should be empty by default - until kivy hosts it's own.
The index that I am hosting isn't granted to be stable (or secure?). It currently hosts every PyProjectRecipe and makes builds faster for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants