Conversation
This is from https://www.uvcentral.com/files/CFFMediaFormat-2_2.pdf Section E.1.1.2 Its in the MPEG file format conformance data, but appears to be legacy in DECE.
WalkthroughThe PR adds support for the AINF atom extension to the codebase. A new 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| let profile_version = u32::decode(buf)?; | ||
| let apid = String::decode(buf)?; | ||
| let remaining = buf.remaining(); | ||
| if remaining != 0 { |
There was a problem hiding this comment.
Possibly, but I'm more interested in flagging this case because the spec says there can be nested boxes, rather than just padding.
Does make me think that up to 8 bytes would be a valid skip case for #112, while this is more "at least a Box" size.
This is from https://www.uvcentral.com/files/CFFMediaFormat-2_2.pdf Section E.1.1.2 Its in the MPEG file format conformance data, but appears to be legacy in DECE.
Resolves #121