Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/workflows/go-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,16 @@ jobs:
# gate step below decides what is actually fatal (net-new crit/high).
run: nox scan ${{ inputs.working-directory }} -format json,sarif -output nox-results || true
- name: Upload SARIF to code scanning
# Best-effort. Code scanning ingest needs GitHub Advanced Security on
# private repos; without it the upload returns "Resource not accessible
# by integration" and would fail the whole Security job. Most of the
# fleet is private, and the gate below -- not this upload -- is the
# enforcement. Same rationale as the taint-plugin install above.
#
# This only became reachable once the filename was corrected from
# findings.sarif to results.sarif: the step had silently skipped since
# it was added, so the permission problem had never surfaced.
continue-on-error: true
if: always() && hashFiles('nox-results/results.sarif') != ''
uses: github/codeql-action/upload-sarif@7211b7c8077ea37d8641b6271f6a365a22a5fbfa # v4
with:
Expand Down
10 changes: 10 additions & 0 deletions .github/workflows/js-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,16 @@ jobs:
# Go-only taint-analysis plugin is intentionally NOT installed here.
run: nox scan ${{ inputs.working-directory }} -format json,sarif -output nox-results || true
- name: Upload SARIF to code scanning
# Best-effort. Code scanning ingest needs GitHub Advanced Security on
# private repos; without it the upload returns "Resource not accessible
# by integration" and would fail the whole Security job. Most of the
# fleet is private, and the gate below -- not this upload -- is the
# enforcement. Same rationale as the taint-plugin install above.
#
# This only became reachable once the filename was corrected from
# findings.sarif to results.sarif: the step had silently skipped since
# it was added, so the permission problem had never surfaced.
continue-on-error: true
# `-output nox-results` writes results.sarif and findings.json. The SARIF
# was looked up as findings.sarif, so hashFiles() never matched and this
# step has silently skipped on every run since it was added — code
Expand Down