chore(ci): bump the fleet nox pin to 1.19.0 - #54
Merged
Conversation
nox shipped 1.17.1, 1.18.0 and 1.19.0 in two days, leaving the pin three
releases behind. warden's own version-drift check refused a release push
over it, correctly.
Measured before moving, scanning every repo with a committed baseline
under BOTH 1.17.0 and 1.19.0 and comparing net-new critical/high -- the
exact condition the shared gate fails on. The control is the point:
counting failures under the new version alone conflates "this bump breaks
it" with "already broken".
25 repos identical, 0 regressions, 4 improved:
axi-go 1 -> 0 SEC-147 gone (Nox-HQ/nox#361)
nomi 11 -> 5 SEC-240 + SEC-435 gone
lexora ERR -> 0 -format now honoured over config (Nox-HQ/nox#362)
nexa ERR -> 0 same
Three of those are fixes for issues filed against nox this morning. The
lexora/nexa change is the most consequential: 1.17.0 let a repo-level
`output.format` silently override the workflow's `-format json,sarif`, so
no findings.json was written and the gate step -- guarded on that file --
skipped, which reads as a green check. 1.19.0 honours the flag.
Also confirmed the OUTGOING sha against 1.17.0's published checksums.txt
before touching it, so the field and method are verified rather than
assumed. Incoming sha is 1.19.0's published linux_amd64 checksum.
Claude-Session: https://claude.ai/code/session_01LMVPJFeTCEtUk2CSNBBBdK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nox shipped 1.17.1, 1.18.0 and 1.19.0 in two days, leaving the pin three releases behind. warden's own version-drift check refused a release push over the gap — correctly, and that is what surfaced this.
Measured before moving
Every repo with a committed
.nox/baseline.jsonscanned under both 1.17.0 and 1.19.0, comparing net-new critical/high — the exact condition the shared gate fails on. The control is the point: counting failures under the new version alone conflates "this bump breaks it" with "already broken".25 repos identical · 0 regressions · 4 improved
axi-goSEC-147gone — the Resend pattern matchingre_inside a Go identifier (Store_Loads…)nomiSEC-240(matched a Go comment) andSEC-435("ghs_fake_install_token") gonelexora-formatnow honoured overoutput.formatin confignexaThree of these are fixes for issues filed against nox this morning (Nox-HQ/nox#361, #362).
The lexora/nexa change is the most consequential. Under 1.17.0 a repo-level
output.format: sarifsilently overrode the workflow's own-format json,sarif, sofindings.jsonwas never written and the gate step — guarded on that file's existence — skipped, which in Actions reads as a green check. Those two repos were passing a gate that never ran. 1.19.0 honours the flag, so the class of failure disappears at the source rather than only being caught by #47.Sha verified in both directions
Before changing it, I confirmed the outgoing value against 1.17.0's published
checksums.txt:That confirms the field and the method rather than assuming them. Each of the three workflows asserted exactly one occurrence of the old version and one of the old sha before rewriting, and all three parse with a duplicate-key-rejecting loader —
yaml.safe_loadaccepts duplicates silently and would not have caught the breakage in #49/#50.No remediation needed first
The standing rule is "remediation PRs first, then the central bump", to stop a bump creating net-new findings. Measurement shows this one creates none and removes six. The ordering does not bind here.
nomi's remaining 5 andkeyward/episteme-api's counts are unchanged by this bump and tracked separately in #46.