chore(release): clear the deprecated goreleaser properties#159
Merged
Conversation
`goreleaser check` reported deprecations that will become hard errors in a future release. These are pure renames with no effect on what is built or published: archives.builds -> archives.ids archives.format: X -> archives.formats: [X] snapshot.name_template -> snapshot.version_template Applied structurally, not by blind search-and-replace: the edit is confined to the top-level `archives:` / `snapshot:` blocks by line range, so a nested `builds:` elsewhere in the file is untouched. A first attempt with an unbounded regex renamed the top-level `builds:` section and broke the config outright -- and reported success, because it only grepped for DEPRECATED lines and an errored run contains none. Verified per repo: YAML parses, the top-level key set is unchanged, and `goreleaser check` runs without a config error. NOT changed here: the `brews` deprecation. Migrating brews -> homebrew_casks publishes Casks/<name>.rb while Formula/<name>.rb remains in the tap, and a tap holding both under one name makes `brew install <name>` ambiguous -- brew prefers the formula, so users silently keep the older artifact. That exact bug was removed from this tap today for preflight, nomi and mnemos. It needs per-repo sequencing (migrate, release, delete the stale formula), not a bulk rename. Claude-Session: https://claude.ai/code/session_01LMVPJFeTCEtUk2CSNBBBdK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
goreleaser checkreports deprecated properties that become hard errors in a future goreleaser. These are pure renames — nothing about what is built or published changes:archives.buildsarchives.idsarchives.format: Xarchives.formats: [X]snapshot.name_templatesnapshot.version_templateApplied structurally, not by search-and-replace
The edit is confined to the top-level
archives:/snapshot:blocks by line range, so a nestedbuilds:elsewhere in the file is untouched.That matters: a first attempt with an unbounded regex renamed the top-level
builds:section, breaking the config completely — and reported success, because it only grepped forDEPRECATEDlines and an errored run contains none. A check that cannot fail is worse than no check.Verified per repo before committing:
goreleaser checkruns without a config errorDeliberately not included:
brewsbrews→homebrew_casksis also deprecated, and is not a rename. It publishesCasks/<name>.rbwhileFormula/<name>.rbremains in the tap — and a tap holding both under one name makesbrew install <name>ambiguous, with brew preferring the formula. Users would silently keep receiving the older artifact.That exact bug was removed from this tap today for
preflight(formula 4.11.1 shadowing cask 4.12.0),nomiandmnemos. Ten repos still usebrews, and every one has a Formula and no Cask, so a bulk migration would recreate it ten times over.It needs per-repo sequencing — migrate, release, delete the stale formula in that order — and is tracked separately.