Move S3 credential guidance into a field tooltip - #304
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 25012772bd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #304 +/- ##
=========================================
Coverage 86.17% 86.17%
Complexity 1447 1447
=========================================
Files 794 794
Lines 83247 83247
Branches 14612 14612
=========================================
+ Hits 71737 71738 +1
+ Misses 11510 11509 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Summary
Move the S3 credential explanation from always-visible text below the selector into the existing help icon beside the Credentials label. The guidance appears on hover or keyboard focus, matching other admin forms.
Escape dismisses the open tooltip while preserving the form and unsaved input. A second Escape retains normal modal dismissal. Update the admin script version so browsers fetch the corrected shared tooltip handler.
Related to #301. Follow-up to #302.
Validation
mvn -pl admin-ui -am test— 38 tests passed.node --test admin-ui/src/test/js/blobstore-credentials.test.js— 6 tests passed. The new Escape regression test failed before the fix.mvn -pl server -am compile -q.git diff --check.Compatibility and design checklist
Notes for reviewers
Uses the existing
field-label,field-help, andicon-infomarkup. The explanation text is unchanged. The shared tooltip handler consumes Escape only while its popover is visible.