fix(steam): stop attributing advertised mods' IDs to an item - #38
Merged
Conversation
Descriptions that advertise other mods by pasting their PZ footer (Workshop ID + Mod ID) leaked those IDs into the item, e.g. 3042138819 reported "TrueMusicJukebox, FunctionalAppliances2". Parse() now attributes each Mod ID / Map Folder to the nearest Workshop ID line (either order) and drops it only when that ID is foreign. Descriptions without the item's own Workshop ID are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parse()scraped everyMod ID:/Map Folder:line, so mods thatadvertise others by pasting their PZ footer leaked foreign IDs:
Now each ID is attributed to the nearest
Workshop ID:line (the pairappears in both orders in the wild) and dropped only when that ID is
foreign. Descriptions without the item's own Workshop ID keep everything.