Skip to content

Panel's title can be not translated #1540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xuaveneg wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Panel's title can be not translated #1540

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/components/panel/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,15 @@ import snakeCase from 'lodash/string/snakeCase';
import ButtonHelp from '../button-help';

const defaultProps = {
actionsPosition: 'top'
actionsPosition: 'top',
titleTranslated: true
};

const propTypes = {
actions: PropTypes.func,
actionsPosition: PropTypes.oneOf(['both', 'bottom', 'top']).isRequired,
title: PropTypes.string,
titleTranslated: PropTypes.bool,
showHelp: PropTypes.bool,
blockName: PropTypes.string
};
Expand All @@ -36,7 +38,7 @@ class Panel extends Component {
* @return {DOM} React DOM element
*/
render() {
const { actions, actionsPosition, children, title, showHelp, blockName, modalTitleId, ...otherProps } = this.props;
const { actions, actionsPosition, children, title, titleTranslated, showHelp, blockName, modalTitleId, ...otherProps } = this.props;
const { spyId } = this.state;
const shouldDisplayActionsTop = actions && ['both', 'top'].includes(actionsPosition);
const shouldDisplayActionsBottom = actions && ['both', 'bottom'].includes(actionsPosition);
Expand All @@ -50,12 +52,12 @@ class Panel extends Component {
<div className='mdl-card mdl-card--border mdl-shadow--4dp' data-spy={spyId} data-focus='panel' {...otherProps}>
{(title || shouldDisplayActionsTop || showHelp) && <div className='mdl-card__title mdl-card--border' data-focus='panel-title'>
{title &&
<h3 data-spy-title {...optionalModalProps}>{this.i18n(title)}</h3>
<h3 data-spy-title {...optionalModalProps}>{titleTranslated ? this.i18n(title) : title}</h3>
}
{shouldDisplayActionsTop &&
<div className='actions'>{actions()}</div>
}
{showHelp && <ButtonHelp blockName={blockName || snakeCase(this.i18n(title)).split('_')[0]} />}
{showHelp && <ButtonHelp blockName={blockName || snakeCase(titleTranslated ? this.i18n(title) : title).split('_')[0]} />}
</div>}
<div className='mdl-card__supporting-text' data-focus='panel-content'>
{children}
Expand Down