feat: Compute multipath in the views and implement thin lenses - #373
Merged
Conversation
kmdouglass
force-pushed
the
multipath_followup
branch
from
June 19, 2026 12:35
3006e8f to
c0d8466
Compare
kmdouglass
force-pushed
the
multipath_followup
branch
from
June 19, 2026 12:40
c0d8466 to
88036f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This continues the refactoring of the multipath feature for systems with beam splitters. The API has been cleaned up a bit and multipath computations have been extended to the views.
I also added a
ThinLenssurface type to make it easier to write test cases for the remaining parts of the multipath system.