-
Notifications
You must be signed in to change notification settings - Fork 0
Refactor like feature and add member nickname field #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kminseok-dev
wants to merge
4
commits into
main
Choose a base branch
from
develop
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,5 @@ | ||
| ## 게시판 만들기 | ||
| - 혼자 공부하면서 백엔드 개발 중 | ||
| - 차츰차츰 여러 기능을 추가하고 있는중 | ||
| # 프로젝트 | ||
|
|
||
| - 개인 프로젝트 | ||
| - spring으로 게시판 만들기 | ||
| - 새로운 기술 적용해 계속 발전시키는 중 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,6 +22,9 @@ public class MemberDto { | |
| @NotBlank(message = "이름을 입력해주세요") | ||
| private String username; | ||
|
|
||
| @NotBlank(message = "닉네임을 입력해주세요") | ||
| private String nickname; | ||
|
Comment on lines
+25
to
+26
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
✏️ 제안 수정- `@NotBlank`(message = "닉네임을 입력해주세요")
+ `@NotBlank`(message = "닉네임을 입력해주세요")
+ `@Size`(min = 2, max = 30, message = "닉네임은 2~30자여야 합니다")
private String nickname;🤖 Prompt for AI Agents |
||
|
|
||
| @NotBlank(message = "이메일을 입력해주세요") | ||
| @Email(message = "이메일 형식이 올바르지 않습니다") | ||
| @Size(max = 255, message = "이메일은 255자 이하여야 합니다") | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/like/{boardId}와/like/{userId}가 동일한 URL 패턴 → 애플리케이션 구동 불가두 엔드포인트의 경로가 모두
GET /api/boards/like/{variable}로 동일합니다. Spring MVC는 경로 변수의 타입(LongvsString)으로 라우팅을 구분하지 않으며, 이 경우IllegalStateException: Ambiguous handler methods예외가 발생합니다. 애플리케이션이 정상적으로 시작되지 않습니다.두 엔드포인트를 구분 가능한 경로로 분리하세요.
🐛 제안 수정
🤖 Prompt for AI Agents