Skip to content
This repository was archived by the owner on Mar 7, 2019. It is now read-only.

Adding ability to embed google maps image#26

Open
jakeboyles wants to merge 58 commits into
kmoe:masterfrom
jakeboyles:master
Open

Adding ability to embed google maps image#26
jakeboyles wants to merge 58 commits into
kmoe:masterfrom
jakeboyles:master

Conversation

@jakeboyles
Copy link
Copy Markdown

Adds ability to embed google maps image.

@jgthms
Copy link
Copy Markdown

jgthms commented Jul 29, 2016

21 commits for changing 30 lines in 2 files? 😐

@jakeboyles
Copy link
Copy Markdown
Author

Started off as just a personal project with other stuff built in then paired it down and decided to submit a pr. Was also testing a lot of heroku stuff that had to be pushed.

@jakeboyles jakeboyles closed this Jul 29, 2016
@jakeboyles jakeboyles reopened this Jul 29, 2016
@kmoe
Copy link
Copy Markdown
Owner

kmoe commented Jul 30, 2016

@jakeboyles Please pull master and rebase (will give you a chance to fix the commits).

Can the Heroku instructions in the README be improved?

@jakeboyles
Copy link
Copy Markdown
Author

jakeboyles commented Jul 31, 2016

Yep, Just wanted to see if there was an interest from you first. I'll update the readme with new instructions.

@jakeboyles
Copy link
Copy Markdown
Author

jakeboyles commented Jul 31, 2016

Welp. It was cool while it lasted. They are blocking all heroku and Cloud based ips. The server will have to be run locally or on your own server.

http://www.forbes.com/sites/ryanmac/2016/07/31/pokemon-go-cuts-off-access-to-pokevision-and-other-creature-finding-apps/#1b54ccce3dba

@kmoe
Copy link
Copy Markdown
Owner

kmoe commented Jul 31, 2016

@jakeboyles do you have another source on that? Happy to run it on my own hardware but I want to be sure first as it's currently working fine.

@jakeboyles
Copy link
Copy Markdown
Author

jakeboyles commented Jul 31, 2016

@kmoe Yeah, I am on the poke.io discord channel and a lot of people are seeing it on there. They may not have discovered the server that yours is running on yet. Just hearing they are rolling them out in batches. Have seen some people get banned as well. Just a warning that they are starting to not be as friendly. I figured it would come sooner than later.

@jakeboyles
Copy link
Copy Markdown
Author

I re based and added in some better docs.

@jakeboyles
Copy link
Copy Markdown
Author

Passing lint now.

@jakeboyles jakeboyles closed this Aug 2, 2016
@jakeboyles jakeboyles reopened this Aug 2, 2016
@jakeboyles jakeboyles closed this Aug 8, 2016
@jakeboyles jakeboyles reopened this Aug 8, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants