This repository was archived by the owner on Mar 7, 2019. It is now read-only.
remove lodash and use es6 / es7#47
Open
InsidersByte wants to merge 1 commit into
Open
Conversation
| "geolib": "^2.0.21", | ||
| "lodash": "^4.14.0", | ||
| "loggly": "^1.1.0", | ||
| "object.values": "^1.0.3", |
Owner
There was a problem hiding this comment.
so... we're replacing lodash with object.values?
Author
There was a problem hiding this comment.
no that's just to shim the Object.values function
| _.forEach(encounters, (encounter) => { | ||
| hbPokemon.push(encounter); | ||
| }); | ||
| const hbPokemon = Object.values(encounters); |
Author
There was a problem hiding this comment.
this is where Object.values is used (see mozilla docs)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.