#30 make output sorted by timestamp#31
Merged
Merged
Conversation
Owner
|
Looks good from the functional side @gintsgints, thanks for looking into the project again! The only thing I'm thinking about is maybe we shouldn't perform sort at all (as could get costly for large rowcounts) - but rather use a different angle - some more deterministic parallelism. Meaning we for example hand out X amount row batches to threads and then later collect output in the same order from threads / workers. But this of course is a biggre change so OK from my side currently |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.