Fix Ctrl-PgUp and Ctrl-PgDn combinations #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Karlson2k
force-pushed
the
pgupdown-mods
branch
from
80d00c0 to
e1b4c01
Compare
Author
|
The patch has been tested locally. |
kdj0c
reviewed
Jan 30, 2026
| case XKB_KEY_KP_Page_Up: | ||
| vte_write(vte, "\e[5~", 4); | ||
| /* Combinations with ALT are handled as TSM_VTE_FLAG_PREPEND_ESCAPE flag */ | ||
| /* if (mods & TSM_ALT_MASK) |
Contributor
There was a problem hiding this comment.
This function is already particularly long, so adding the commented code here looks a bit too much. Can you remove it? (But keep the first comment about TSM_VTE_FLAG_PREPEND_ESCAPE flag).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for kmscon/kmscon#259.