Strengthen regression coverage for #25 and #26 - #55
Merged
Merged
Conversation
knifecake
marked this pull request as ready for review
September 6, 2026 17:58
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 54a2a68dab
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This was referenced Sep 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The claiming regression in #25 and the missing-process logging error in #26 need tests that detect the original failures. The existing pool test passed even with the broken logging code because it only checked that
perform()ran and never inspected the executor's Future.Future.result(timeout=5)so background exceptions fail the test. Check completion logging, restored capacity, and the idle callback.Validation:
uv run python runtests.py, with database URLs on port 55439 because local port 5432 is occupied).make lintand commit hooks passed.lock_candidates()makes the new claiming test fail because it returns no claimed jobs; restoring pre-Fix process supervision race conditions #29Pool.post()makes the strengthened pool test raise the reportedAttributeError. Both tests pass with current implementations.Related to #25 and #26. These tests establish coverage for specific failure paths; they do not establish that every cause of either report is resolved.