Reset database state before replacement workers fork - #56
Merged
Merged
Conversation
knifecake
marked this pull request as ready for review
September 6, 2026 18:14
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a supervised worker dies,
replace_fork()queries the database to recover its claimed jobs. This reopens the PostgreSQL connection and pool after the startup cleanup, andstart_process()previously forked before resetting that state in the parent.Reset database connections and pool caches immediately before each
os.fork(). Keep the existing startup, parent, and child cleanup, and preserve pooling configuration.Add PostgreSQL transaction tests that use real connections and pools and intercept only
os.fork(). They verify cleanup at the fork boundary for direct starts and replacements following claimed-job recovery, preservation of pooling options, and successful recovery of the dead worker's job. Both tests failed on the prior implementation with an open psycopg connection at the fork boundary.Validation:
uv run python runtests.pywith database URLs on port 55439).make lintand commit hooks passed.Related to #48; intentionally leaves it open. This fixes a demonstrated cleanup-ordering gap, not a reproduced macOS SIGSEGV. It does not establish that forking alongside background threads is safe or eliminate every possible source of inherited state.