Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/claude.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ jobs:
with:
claude_code_oauth_token: ${{ secrets.CLAUDE_CODE_OAUTH_TOKEN }}
github_token: ${{ secrets.GITHUB_TOKEN }}
allowed_bots: Copilot,app/copilot,dependabot,github-actions
trigger_phrase: '@claude'
mode: agent
assignee_trigger: claude
Expand Down Expand Up @@ -105,6 +106,7 @@ jobs:
with:
claude_code_oauth_token: ${{ secrets.CLAUDE_CODE_OAUTH_TOKEN }}
github_token: ${{ secrets.GITHUB_TOKEN }}
allowed_bots: Copilot,app/copilot,dependabot,github-actions
trigger_phrase: '@claude'
assignee_trigger: claude
mode: agent
Expand All @@ -128,6 +130,7 @@ jobs:
with:
claude_code_oauth_token: ${{ secrets.CLAUDE_CODE_OAUTH_TOKEN }}
github_token: ${{ secrets.GITHUB_TOKEN }}
allowed_bots: Copilot,app/copilot,dependabot,github-actions
trigger_phrase: '@claude'
assignee_trigger: claude
label_trigger: claude
Expand All @@ -151,6 +154,7 @@ jobs:
with:
claude_code_oauth_token: ${{ secrets.CLAUDE_CODE_OAUTH_TOKEN }}
github_token: ${{ secrets.GITHUB_TOKEN }}
allowed_bots: Copilot,app/copilot,dependabot,github-actions
trigger_phrase: '@claude'
assignee_trigger: claude
mode: agent
Expand Down
3 changes: 2 additions & 1 deletion crates/ast-engine/src/tree_sitter/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,7 @@ fn parse_lang(
///
/// ```rust,no_run
/// # use thread_ast_engine::tree_sitter::StrDoc;
/// # #[derive(Clone, Debug)]
/// # struct JavaScript;
/// # impl thread_ast_engine::Language for JavaScript {
/// # fn kind_to_id(&self, _: &str) -> u16 { 0 }
Expand Down Expand Up @@ -401,7 +402,7 @@ pub fn perform_edit<S: ContentExt>(tree: &mut Tree, input: &mut S, edit: &Edit<S
/// use thread_ast_engine::tree_sitter::{LanguageExt, TSLanguage};
/// use thread_ast_engine::Language;
///
/// #[derive(Clone)]
/// #[derive(Clone, Debug)]
/// struct JavaScript;
///
/// impl Language for JavaScript {
Expand Down
3 changes: 3 additions & 0 deletions crates/ast-engine/src/tree_sitter/traversal.rs
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
//! # use thread_ast_engine::tree_sitter::traversal::Visitor;
//! # use thread_ast_engine::Language;
//! # use thread_ast_engine::tree_sitter::LanguageExt;
//! # #[derive(Clone, Debug)]
//! # struct Tsx;
//! # impl thread_ast_engine::Language for Tsx {
//! # fn kind_to_id(&self, _: &str) -> u16 { 0 }
Expand Down Expand Up @@ -56,6 +57,7 @@
//! # use thread_ast_engine::tree_sitter::traversal::Visitor;
//! # use thread_ast_engine::Language;
//! # use thread_ast_engine::tree_sitter::LanguageExt;
//! # #[derive(Clone, Debug)]
//! # struct Tsx;
//! # impl thread_ast_engine::Language for Tsx {
//! # fn kind_to_id(&self, _: &str) -> u16 { 0 }
Expand Down Expand Up @@ -117,6 +119,7 @@ use std::marker::PhantomData;
/// # use thread_ast_engine::tree_sitter::traversal::Visitor;
/// # use thread_ast_engine::Language;
/// # use thread_ast_engine::tree_sitter::LanguageExt;
/// # #[derive(Clone, Debug)]
/// # struct Tsx;
/// # impl thread_ast_engine::Language for Tsx {
/// # fn kind_to_id(&self, _: &str) -> u16 { 0 }
Expand Down
6 changes: 3 additions & 3 deletions crates/language/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1721,17 +1721,17 @@ pub fn from_extension(path: &Path) -> Option<SupportLang> {
}

// Handle extensionless files or files with unknown extensions
if let Some(_file_name) = path.file_name().and_then(|n| n.to_str()) {
if let Some(file_name) = path.file_name().and_then(|n| n.to_str()) {
// 1. Check if the full filename matches a known extension (e.g. .bashrc)
#[cfg(any(feature = "bash", feature = "all-parsers"))]
if constants::BASH_EXTS.contains(&_file_name) {
if constants::BASH_EXTS.contains(&file_name) {
return Some(SupportLang::Bash);
}

// 2. Check known extensionless file names
#[cfg(any(feature = "bash", feature = "all-parsers", feature = "ruby"))]
for (name, lang) in constants::LANG_RELATIONSHIPS_WITH_NO_EXTENSION {
if *name == _file_name {
if *name == file_name {
return Some(*lang);
}
}
Expand Down
82 changes: 82 additions & 0 deletions crates/services/src/types.rs
Original file line number Diff line number Diff line change
Expand Up @@ -631,3 +631,85 @@ impl Range {
self.start <= other.end && other.start <= self.end
}
}

#[cfg(test)]
mod range_tests {
use super::*;

// Helper to create positions
#[cfg(feature = "ast-grep-backend")]
fn pos(line: usize, byte_column: usize, byte_offset: usize) -> Position {
Position::new(line, byte_column, byte_offset)
}

#[cfg(not(feature = "ast-grep-backend"))]
fn pos(row: usize, column: usize, index: usize) -> Position {
Position::new(row, column, index)
}

#[test]
fn test_range_contains() {
let start = pos(1, 5, 15);
let end = pos(3, 10, 45);
let range = Range::new(start, end);

// Before range
assert!(!range.contains(pos(1, 4, 14)));
assert!(!range.contains(pos(0, 5, 5)));

// Exactly at start
assert!(range.contains(pos(1, 5, 15)));

// Inside range
assert!(range.contains(pos(2, 0, 25)));

// Exactly at end
assert!(range.contains(pos(3, 10, 45)));

// After range
assert!(!range.contains(pos(3, 11, 46)));
assert!(!range.contains(pos(4, 0, 50)));
}

#[test]
fn test_range_overlaps() {
let base_start = pos(2, 5, 25);
let base_end = pos(4, 10, 55);
let base = Range::new(base_start, base_end);

// 1. Completely before (no overlap)
let before = Range::new(pos(1, 0, 10), pos(2, 4, 24));
assert!(!base.overlaps(&before));
assert!(!before.overlaps(&base));

// 2. Ending exactly at start (overlap)
let abut_before = Range::new(pos(1, 0, 10), pos(2, 5, 25));
assert!(base.overlaps(&abut_before));
assert!(abut_before.overlaps(&base));
Comment on lines +685 to +688
Copy link

Copilot AI Mar 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comments say abutting at the boundary is an overlap; that documents an inclusive overlap definition. If the public semantics are intended to be half-open ([start, end)) or treat abutting as non-overlapping, these tests will lock in the wrong contract. Please align the test expectations/comments with the intended Range semantics (and consider a short doc comment on Range::overlaps/Range::contains clarifying inclusivity).

Copilot uses AI. Check for mistakes.

// 3. Overlapping start
let overlap_start = Range::new(pos(1, 0, 10), pos(3, 0, 35));
assert!(base.overlaps(&overlap_start));
assert!(overlap_start.overlaps(&base));

// 4. Completely inside
let inside = Range::new(pos(3, 0, 35), pos(3, 5, 40));
assert!(base.overlaps(&inside));
assert!(inside.overlaps(&base));

// 5. Overlapping end
let overlap_end = Range::new(pos(3, 0, 35), pos(5, 0, 65));
assert!(base.overlaps(&overlap_end));
assert!(overlap_end.overlaps(&base));

// 6. Starting exactly at end (overlap)
let abut_after = Range::new(pos(4, 10, 55), pos(5, 0, 65));
assert!(base.overlaps(&abut_after));
assert!(abut_after.overlaps(&base));
Comment on lines +705 to +708
Copy link

Copilot AI Mar 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comments say abutting at the boundary is an overlap; that documents an inclusive overlap definition. If the public semantics are intended to be half-open ([start, end)) or treat abutting as non-overlapping, these tests will lock in the wrong contract. Please align the test expectations/comments with the intended Range semantics (and consider a short doc comment on Range::overlaps/Range::contains clarifying inclusivity).

Copilot uses AI. Check for mistakes.

// 7. Completely after (no overlap)
let after = Range::new(pos(4, 11, 56), pos(5, 0, 65));
assert!(!base.overlaps(&after));
assert!(!after.overlaps(&base));
}
}
Loading