Add configurations, Best Item Mode and Info Display Mode#21
Open
TYTheBeast wants to merge 27 commits into
Open
Add configurations, Best Item Mode and Info Display Mode#21TYTheBeast wants to merge 27 commits into
TYTheBeast wants to merge 27 commits into
Conversation
…ion mode - Introduced a new `BestItemMode` enum in `config.rs` to allow users to specify how the best item is determined (Default, Platinum, Ducats). - Updated the `run_detection` function in `main.rs` to accept an `Arguments` struct, enabling the selection of the best item mode based on user input. - Modified item evaluation logic to accommodate the new best item mode options. - Updated the `Arguments` struct to include a new command-line argument for best item mode with a default value.
- Introduced `InfoMode` enum in `config.rs` to toggle between default and detailed item information display. - Updated `Item` struct in `database.rs` to include `yesterday_vol` and `today_vol` for tracking item volume. - Modified price data deserialization in `wfinfo_data.rs` to accommodate new volume fields. - Enhanced logging in `main.rs` to display volume information based on the selected `InfoMode`. - Updated command-line arguments to include `info_mode` for user-defined output preferences.
- Introduced `Volatility` variant to the `BestItemMode` enum in `config.rs`. - Updated the item evaluation logic in `run_detection` function of `main.rs` to calculate item value based on the new `Volatility` mode (Platinum * (Yesterday Vol + Today Vol)). - Enhanced documentation for command-line arguments to reflect the addition of the `volatility` mode.
Also updated volatility formula to better reflect market changes
… arguments - Introduced a new `Minimal` variant to the `InfoMode` enum in `config.rs` for simplified item information display. - Updated the default value of `info_mode` in the `Arguments` struct to `minimal`, changing the output format to show only the item name, platinum, and ducats. - Enhanced documentation for `info_mode` to reflect the new `minimal` option.
…`InfoMode::Combined` and `InfoMode::All`. Updated output strings to ensure proper display of item name, platinum, ducats, and volume information, maintaining consistency across different info modes.
… references in `main.rs`.
Forma-config
…streamline code and reduce unnecessary file generation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Best Item Mode, Info Display Options, and Snap-it Feature
Overview
This PR enhances the reward analysis system with configurable evaluation modes, display formats, and a new Snap-it feature for individual item checking.
Key Features
Best Item Mode Selection
Combined: Balanced scoring of Platinum + Ducats (default)Platinum: Pure platinum value prioritizationDucats: Pure ducat value prioritizationVolatility: Market-based scoring using sales volume trendsFlexible Display Formats
Minimal: Streamlined output showing name, platinum, and ducatsCombined: Added context with labeled valuesAll: Comprehensive view including trading volume metricsNew Snap-it Feature
Technical Implementation
Testing
Documentation