Skip to content

fix: handle BC null-date sentinel on project header dates #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EdiWeeks merged 2 commits into from
May 5, 2026
Merged

fix: handle BC null-date sentinel on project header dates #200

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b0a5b92
fix: handle BC null-date sentinel on project header dates
EdiWeeks May 5, 2026
3f6adae
docs: reword formatDate comment to lead with observed symptom
EdiWeeks May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions src/components/projects/ProjectHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,22 +15,22 @@ import {
} from '@heroicons/react/24/outline';
import { useProjectDetailsStore } from '@/hooks/useProjectDetailsStore';
import { useCompanyStore } from '@/hooks';
import { getBCJobUrl } from '@/utils';
import { cn } from '@/utils';
import { cn, DATE_FORMAT_FULL, formatDate as formatDateUtil, getBCJobUrl } from '@/utils';
import type { BillingMode } from '@/services/bc/projectDetailsService';

/**
* Format a date string for display (e.g., "15 Jan 2025")
* Format a date string for display (e.g., "15 Jan 2025").
*
* Treats BC's null-date sentinel ("0001-..." — typically "0001-01-01") as
* unspecified. The sentinel arrives as a non-empty ISO string, so the
* empty-check alone misses it; `new Date(...).toLocaleDateString` then
* renders it as e.g. "31 Dec 1" — the timezone shift in negative-UTC zones
* flips the calendar day, and the year prints unpadded as "1".
*/
function formatDate(dateStr?: string): string {
if (!dateStr) return 'Unspecified';
if (!dateStr || dateStr.startsWith('0001-')) return 'Unspecified';
try {
const date = new Date(dateStr);
return date.toLocaleDateString('en-GB', {
day: 'numeric',
month: 'short',
year: 'numeric',
});
return formatDateUtil(dateStr, DATE_FORMAT_FULL);
} catch {
return 'Unspecified';
}
Expand Down
Loading