Skip to content

sm8250: support current ABL boot requirements #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
updawg wants to merge 3 commits into
base: knulli-main
Choose a base branch
from
Open

sm8250: support current ABL boot requirements #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a7e8b64
Fix SM8250 boot FAT cluster size
updawg Jul 28, 2026
8d1cf37
Map SM8250 power key to GRUB enter
updawg Jul 28, 2026
2eacf2a
Clear queued SM8250 input before GRUB menu
updawg Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion board/qualcomm/sm8250/genimage.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
image boot.vfat {
vfat {
extraargs = "-F 32 -n KNULLI"
extraargs = "-F 32 -s 32 -n KNULLI"
@files
}

Expand Down
34 changes: 34 additions & 0 deletions board/qualcomm/sm8250/patches/grub2/001-map-suspend-key-to-enter.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
--- a/grub-core/term/efi/console.c
+++ b/grub-core/term/efi/console.c
@@ -204,6 +204,8 @@
GRUB_TERM_KEY_F10, GRUB_TERM_KEY_F11, GRUB_TERM_KEY_F12, GRUB_TERM_ESC
};

+#define GRUB_EFI_SCAN_SUSPEND 0x0102
+
static int
grub_efi_translate_key (grub_efi_input_key_t key)
{
@@ -222,6 +224,9 @@
/* Some devices send enter with scan_code 0x0d (F3) and unicode_char 0x0d. */
else if (key.scan_code == '\r' && key.unicode_char == '\r')
return key.unicode_char;
+ /* Qualcomm firmware reports the power button as EFI_SCAN_SUSPEND. */
+ else if (key.scan_code == GRUB_EFI_SCAN_SUSPEND)
+ return '\r';
else if (key.scan_code < ARRAY_SIZE (efi_codes))
return efi_codes[key.scan_code];

@@ -365,6 +370,12 @@
text_input = grub_efi_open_protocol(grub_efi_system_table->console_in_handler,
&text_input_ex_guid,
GRUB_EFI_OPEN_PROTOCOL_GET_PROTOCOL);
+
+ /* Discard keys queued by firmware before GRUB took over input. This is
+ particularly important when the power button is also used as Enter. */
+ if (text_input)
+ text_input->reset (text_input, 0);
+
term->data = (void *)text_input;

return 0;
2 changes: 1 addition & 1 deletion board/qualcomm/sm8250/rp5/genimage.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
image boot.vfat {
vfat {
extraargs = "-F 32 -n KNULLI"
extraargs = "-F 32 -s 32 -n KNULLI"
@files
}

Expand Down
2 changes: 1 addition & 1 deletion board/qualcomm/sm8250/rpflip2/genimage.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
image boot.vfat {
vfat {
extraargs = "-F 32 -n KNULLI"
extraargs = "-F 32 -s 32 -n KNULLI"
@files
}

Expand Down
2 changes: 1 addition & 1 deletion board/qualcomm/sm8250/rpmini/genimage.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
image boot.vfat {
vfat {
extraargs = "-F 32 -n KNULLI"
extraargs = "-F 32 -s 32 -n KNULLI"
@files
}

Expand Down
2 changes: 1 addition & 1 deletion board/qualcomm/sm8250/rpminiv2/genimage.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
image boot.vfat {
vfat {
extraargs = "-F 32 -n KNULLI"
extraargs = "-F 32 -s 32 -n KNULLI"
@files
}

Expand Down