fix: remove emrldco analytics and improve basemap fallback#1052
Merged
Conversation
- Remove emrldco.com analytics script and CSP entries from index.html, vercel.json, and tauri.conf.json - Replace setStyle() basemap fallback with full map recreation — setStyle() after a failed initial style load leaves MapLibre in a broken state - Add 403/Forbidden to error detection patterns for basemap failures - Scope fallback to pre-style-load errors only (post-load tile errors don't warrant destroying a working map)
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
index.html,vercel.json, andtauri.conf.jsonsetStyle()approach left MapLibre in a broken state where the map never rendered. Now weremove()the failed map and create a fresh one with the OpenFreeMap fallback URL403/Forbiddento the error pattern matchingContext
A user reported a blank map + console errors. Root cause: Carto style.json returned 403 intermittently, and
setStyle()on a map whose initial style never loaded doesn't reliably recover MapLibre's rendering pipeline.Test plan
basemaps.cartocdn.comin DevTools Network) → map should recreate with OpenFreeMap within 5semrldco.comscript or CSP references remain