fix: auto-reload on SW activation to prevent stale bundle 404s#1061
Merged
fix: auto-reload on SW activation to prevent stale bundle 404s#1061
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
When a new SW takes control (after deploy), automatically reload the page so users get fresh HTML + correct bundle hashes. Prevents the one-time 404 on first load after deploy where old SW serves stale HTML.
c41254e to
2113d9e
Compare
4 tasks
aldoyh
pushed a commit
to aldoyh/worldmonitor
that referenced
this pull request
Mar 6, 2026
When a new SW takes control (after deploy), automatically reload the page so users get fresh HTML + correct bundle hashes. Prevents the one-time 404 on first load after deploy where old SW serves stale HTML.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After a deploy, users with a cached service worker see 404s on first load because the old SW serves stale HTML referencing old content-hashed bundles. The browser detects the new sw.js and installs it in the background, but the page is already broken.
This adds a
controllerchangelistener that auto-reloads the page when the new SW takes control. Combined withskipWaiting+clientsClaim, this means: user loads page → old SW serves stale HTML → 404 → new SW installs + activates →controllerchangefires → page auto-reloads → new SW serves fresh HTML → works.Test plan
refreshingflag)