fix: InsightsPanel exits loading state on finance/tech variants#1068
Merged
fix: InsightsPanel exits loading state on finance/tech variants#1068
Conversation
The InsightsPanel on finance/tech variants stayed spinning indefinitely because updateInsights was only called when latestClusters.length > 0. When clustering produced zero results (common for non-geopolitical variants), the panel never transitioned out of showLoading(). - Remove the length > 0 guard so updateInsights always fires - Call updateInsights([]) in catch block so clustering errors also clear the loading spinner
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
aldoyh
pushed a commit
to aldoyh/worldmonitor
that referenced
this pull request
Mar 6, 2026
…#1068) The InsightsPanel on finance/tech variants stayed spinning indefinitely because updateInsights was only called when latestClusters.length > 0. When clustering produced zero results (common for non-geopolitical variants), the panel never transitioned out of showLoading(). - Remove the length > 0 guard so updateInsights always fires - Call updateInsights([]) in catch block so clustering errors also clear the loading spinner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
finance.worldmonitor.appandtech.worldmonitor.appstayed spinning indefinitelyupdateInsights()was only called whenlatestClusters.length > 0— these variants often produce zero clusters, so the panel never transitioned out ofshowLoading()updateInsightsalways fires (it already handles empty arrays gracefully)updateInsights([])in the clustering catch block so errors also clear the spinnerTest plan
finance.worldmonitor.appInsightsPanel shows content or "waiting for data" instead of spinningtech.worldmonitor.appInsightsPanel behaves the samewww.worldmonitor.appInsightsPanel still works normallynpx tsc --noEmitpasses)