Skip to content

ci: add typecheck step before desktop build to fail fast#818

Open
NewCoder3294 wants to merge 1 commit intokoala73:mainfrom
NewCoder3294:ci/desktop-build-typecheck
Open

ci: add typecheck step before desktop build to fail fast#818
NewCoder3294 wants to merge 1 commit intokoala73:mainfrom
NewCoder3294:ci/desktop-build-typecheck

Conversation

@NewCoder3294
Copy link
Contributor

Summary

  • Adds a new typecheck job to the desktop build workflow that runs tsc --noEmit before any platform builds begin
  • The build-tauri matrix jobs now depend on this typecheck job via needs: typecheck, so all 5 platform builds are gated behind the type check passing
  • The typecheck job runs on ubuntu-latest with a 5-minute timeout, keeping it lightweight and fast

Motivation

The desktop build workflow runs a 30+ minute Tauri build across 5 platforms (2 macOS, 1 Windows, 2 Linux). If there is a TypeScript type error, developers currently have to wait for the full build to fail before discovering it. By adding a quick typecheck step that runs first, type errors are caught in under 2 minutes instead of 30+, saving significant CI time and developer frustration.

Test plan

  • Verify the workflow YAML is valid (no syntax errors)
  • Confirm typecheck job runs before build-tauri jobs in the workflow graph
  • Confirm that a type error would cause the typecheck job to fail and skip all build-tauri jobs

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@vercel
Copy link

vercel bot commented Mar 2, 2026

@NewCoder3294 is attempting to deploy a commit to the Elie Team on Vercel.

A member of the Team first needs to authorize it.

@koala73 koala73 added Ready to Merge PR is mergeable, passes checks, and adds value High Value Meaningful contribution to the project labels Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

High Value Meaningful contribution to the project Ready to Merge PR is mergeable, passes checks, and adds value

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants