ci: add typecheck step before desktop build to fail fast#818
Open
NewCoder3294 wants to merge 1 commit intokoala73:mainfrom
Open
ci: add typecheck step before desktop build to fail fast#818NewCoder3294 wants to merge 1 commit intokoala73:mainfrom
NewCoder3294 wants to merge 1 commit intokoala73:mainfrom
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
@NewCoder3294 is attempting to deploy a commit to the Elie Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
typecheckjob to the desktop build workflow that runstsc --noEmitbefore any platform builds beginbuild-taurimatrix jobs now depend on this typecheck job vianeeds: typecheck, so all 5 platform builds are gated behind the type check passingubuntu-latestwith a 5-minute timeout, keeping it lightweight and fastMotivation
The desktop build workflow runs a 30+ minute Tauri build across 5 platforms (2 macOS, 1 Windows, 2 Linux). If there is a TypeScript type error, developers currently have to wait for the full build to fail before discovering it. By adding a quick typecheck step that runs first, type errors are caught in under 2 minutes instead of 30+, saving significant CI time and developer frustration.
Test plan
🤖 Generated with Claude Code